From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35B23A0613 for ; Fri, 30 Aug 2019 10:55:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4E791E8E7; Fri, 30 Aug 2019 10:55:38 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C53E51E8E6 for ; Fri, 30 Aug 2019 10:55:37 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F09BA3082DDD; Fri, 30 Aug 2019 08:55:36 +0000 (UTC) Received: from [10.36.112.16] (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9305960872; Fri, 30 Aug 2019 08:55:35 +0000 (UTC) To: Noa Ezra , "tiwei.bie@intel.com" , "zhihong.wang@intel.com" Cc: Matan Azrad , "dev@dpdk.org" References: <1560924898-221025-1-git-send-email-noae@mellanox.com> From: Maxime Coquelin Openpgp: preference=signencrypt Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Fri, 30 Aug 2019 10:55:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 30 Aug 2019 08:55:37 +0000 (UTC) Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH] net/vhost: add an API for get queue status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Noa, I was thinking about an alternative that would avoid adding an API. What about the Vhost-user library to replay the queue status for all configured queues when the device is ready (i.e. after it has called its .new_device() callback)? On 6/24/19 1:08 PM, Noa Ezra wrote: > Hi, > What do you say about this patch? > > Thanks, > Noa. > >> -----Original Message----- >> From: Noa Ezra [mailto:noae@mellanox.com] >> Sent: Wednesday, June 19, 2019 9:15 AM >> To: maxime.coquelin@redhat.com >> Cc: Matan Azrad ; dev@dpdk.org; Noa Ezra >> >> Subject: [Suspected-Phishing][PATCH] net/vhost: add an API for get queue >> status >> >> Add an API that returns queue status for requested queue in the port. >> The queue's status can be changed before the user has signed for the queue >> state event interrupt. In this case the user can't know the current queue's >> status. This API returns the current status. >> >> Signed-off-by: Noa Ezra >> Reviewed-by: Matan Azrad >> --- >> drivers/net/vhost/rte_eth_vhost.c | 47 >> +++++++++++++++++++++++++++++ >> drivers/net/vhost/rte_eth_vhost.h | 18 +++++++++++ >> drivers/net/vhost/rte_pmd_vhost_version.map | 6 ++++ >> 3 files changed, 71 insertions(+) >> >> diff --git a/drivers/net/vhost/rte_eth_vhost.c >> b/drivers/net/vhost/rte_eth_vhost.c >> index 9a54020..cad1e5c 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.c >> +++ b/drivers/net/vhost/rte_eth_vhost.c >> @@ -855,6 +855,7 @@ struct vhost_xstats_name_off { >> /* won't be NULL */ >> state = vring_states[eth_dev->data->port_id]; >> rte_spinlock_lock(&state->lock); >> + >> state->cur[vring] = enable; >> state->max_vring = RTE_MAX(vring, state->max_vring); >> rte_spinlock_unlock(&state->lock); >> @@ -874,6 +875,52 @@ struct vhost_xstats_name_off { }; >> >> int >> +rte_eth_vhost_get_queue_status(uint16_t port_id, bool rx, uint16_t >> queue_id, >> + bool *queue_status) >> +{ >> + struct rte_vhost_vring_state *state; >> + struct internal_list *list; >> + struct rte_eth_dev *eth_dev; >> + int found = 0; >> + uint16_t nb_q = 0; >> + >> + if (port_id >= RTE_MAX_ETHPORTS) { >> + VHOST_LOG(ERR, "Invalid port id\n"); >> + return -1; >> + } >> + TAILQ_FOREACH(list, &internal_list, next) { >> + eth_dev = list->eth_dev; >> + if (eth_dev->data->port_id == port_id) { >> + nb_q = rx ? eth_dev->data->nb_rx_queues : >> + eth_dev->data->nb_tx_queues; >> + found = 1; >> + break; >> + } >> + } >> + if (!found) { >> + VHOST_LOG(ERR, "No device found for port id %u\n", >> port_id); >> + return -1; >> + } >> + if (queue_id >= nb_q) { >> + VHOST_LOG(ERR, "Invalid queue id\n"); >> + return -1; >> + } >> + >> + state = vring_states[port_id]; >> + if (!state) { >> + VHOST_LOG(ERR, "Unused port\n"); >> + return -1; >> + } >> + >> + rte_spinlock_lock(&state->lock); >> + *queue_status = rx ? state->cur[queue_id * 2 + 1] : >> + state->cur[queue_id * 2]; >> + rte_spinlock_unlock(&state->lock); >> + >> + return 0; >> +} >> + >> +int >> rte_eth_vhost_get_queue_event(uint16_t port_id, >> struct rte_eth_vhost_queue_event *event) { diff --git >> a/drivers/net/vhost/rte_eth_vhost.h b/drivers/net/vhost/rte_eth_vhost.h >> index 0e68b9f..1e65c69 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.h >> +++ b/drivers/net/vhost/rte_eth_vhost.h >> @@ -44,6 +44,24 @@ int rte_eth_vhost_get_queue_event(uint16_t port_id, >> struct rte_eth_vhost_queue_event *event); >> >> /** >> + * Get queue status for specific queue in the port. >> + * >> + * @param[in] port_id >> + * Port id. >> + * @param[in] rx >> + * True is rx, False if tx >> + * @paran[in] queue_id >> + * Queue_id >> + * @param[out] queue_status >> + * Pointer to a boolean, True is enable, False if disable. >> + * @return >> + * - On success, zero, queue_status is updated. >> + * - On failure, a negative value, queue_status is not updated. >> + */ >> +int rte_eth_vhost_get_queue_status(uint16_t port_id, bool rx, uint16_t >> queue_id, >> + bool *queue_status); >> + >> +/** >> * Get the 'vid' value associated with the specified port. >> * >> * @return >> diff --git a/drivers/net/vhost/rte_pmd_vhost_version.map >> b/drivers/net/vhost/rte_pmd_vhost_version.map >> index 695db85..1eabfd2 100644 >> --- a/drivers/net/vhost/rte_pmd_vhost_version.map >> +++ b/drivers/net/vhost/rte_pmd_vhost_version.map >> @@ -11,3 +11,9 @@ DPDK_16.11 { >> >> rte_eth_vhost_get_vid_from_port_id; >> }; >> + >> +DPDK_19.08 { >> + global: >> + >> + rte_eth_vhost_get_queue_status; >> +}; >> -- >> 1.8.3.1 >