From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0A8D45AF2; Wed, 9 Oct 2024 14:08:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCD0240E25; Wed, 9 Oct 2024 14:08:28 +0200 (CEST) Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by mails.dpdk.org (Postfix) with ESMTP id 8FAEA4065D for ; Wed, 9 Oct 2024 14:08:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1728475708; x=1760011708; h=from:to:cc:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version:subject; bh=NI+ZpG5Q25l8NrKVLPLuV+s554PQm00P6k28K+EWICU=; b=p+jUp3ChnPjMdPW8oHWpsZTl+5kQPh43ySPEzRjtpk8T9uCGyWirDdOV QSv7SFaTCJl34JnIJMBvJrXQEgtMMwaInfY1LSut5KvlD6XaEJIATNtOA 8Cr0JJKK78ovB4i/hTZKSdKFhzqdIxFoO72fX3jJ21/xWS+VSax3kFa1a 8=; X-IronPort-AV: E=Sophos;i="6.11,189,1725321600"; d="scan'208";a="374627130" Subject: RE: [PATCH] net/ena: remove unused abort macro Thread-Topic: [PATCH] net/ena: remove unused abort macro Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2024 12:08:21 +0000 Received: from EX19MTAEUB001.ant.amazon.com [10.0.43.254:33838] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.16.199:2525] with esmtp (Farcaster) id 8f7cbd3d-aa43-44d0-93f0-ca7e8a5cef81; Wed, 9 Oct 2024 12:08:19 +0000 (UTC) X-Farcaster-Flow-ID: 8f7cbd3d-aa43-44d0-93f0-ca7e8a5cef81 Received: from EX19D023EUA003.ant.amazon.com (10.252.50.101) by EX19MTAEUB001.ant.amazon.com (10.252.51.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Wed, 9 Oct 2024 12:08:19 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D023EUA003.ant.amazon.com (10.252.50.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Wed, 9 Oct 2024 12:08:19 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.035; Wed, 9 Oct 2024 12:08:19 +0000 From: "Brandes, Shai" To: Thomas Monjalon , "dev@dpdk.org" CC: "Schmeilin, Evgeny" , "Beider, Ron" , "Bernstein, Amit" , "Atrash, Wajeeh" Thread-Index: AQHbGkFz6Z8a3Vb+n0q1INs5Y2aRjrJ+UoWA Date: Wed, 9 Oct 2024 12:08:19 +0000 Message-ID: References: <20241009114921.1231790-1-thomas@monjalon.net> In-Reply-To: <20241009114921.1231790-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.95.86.162] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, October 9, 2024 2:49 PM > To: dev@dpdk.org > Cc: Brandes, Shai ; Schmeilin, Evgeny > ; Beider, Ron ; Bernstein, > Amit ; Atrash, Wajeeh > Subject: [EXTERNAL] [PATCH] net/ena: remove unused abort macro >=20 > CAUTION: This email originated from outside of the organization. Do not c= lick > links or open attachments unless you can confirm the sender and know the > content is safe. >=20 >=20 >=20 > The function abort() should be forbidden for drivers and libs. > It is not used in ENA, but the rule is enfocred by removing the macro. >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/net/ena/base/ena_plat_dpdk.h | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h > b/drivers/net/ena/base/ena_plat_dpdk.h > index 21b96113c7..a41a4e4506 100644 > --- a/drivers/net/ena/base/ena_plat_dpdk.h > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > @@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t; >=20 > #define ENA_CDESC_RING_SIZE_ALIGNMENT (1 << 12) /* 4K */ >=20 > -#define ENA_ABORT() abort() > - > #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000) #define > ENA_USLEEP(x) rte_delay_us_sleep(x) #define ENA_UDELAY(x) > rte_delay_us_block(x) > -- > 2.46.0 [Brandes, Shai] Thanks Thomas, we verified this in our CI. Acked-by: Shai Brandes