From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C1B43258; Wed, 1 Nov 2023 07:07:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D037940270; Wed, 1 Nov 2023 07:07:00 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 97322400EF for ; Wed, 1 Nov 2023 07:06:59 +0100 (CET) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SKxGs5CWqzvPx8; Wed, 1 Nov 2023 14:01:57 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 1 Nov 2023 14:06:56 +0800 Message-ID: Date: Wed, 1 Nov 2023 14:06:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/9] ethdev: overwrite some comment related to RSS To: Ori Kam , "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko CC: "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liudongdong3@huawei.com" References: <20231011092805.693171-1-haijie1@huawei.com> <20231027092836.445224-1-haijie1@huawei.com> <20231027092836.445224-2-haijie1@huawei.com> From: Jie Hai In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/29 15:26, Ori Kam wrote: > Hi Jei, > >> -----Original Message----- >> From: Jie Hai >> Sent: Friday, October 27, 2023 12:28 PM >> >> 1. overwrite the comments of fields of 'rte_eth_rss_conf'. >> 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. >> >> Signed-off-by: Jie Hai >> --- >> lib/ethdev/rte_ethdev.h | 33 ++++++++++++++++++--------------- >> lib/ethdev/rte_flow.h | 1 + >> 2 files changed, 19 insertions(+), 15 deletions(-) >> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index 2fd3cd808dbf..37fd5afef48a 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -448,24 +448,27 @@ struct rte_vlan_filter_conf { >> /** >> * A structure used to configure the Receive Side Scaling (RSS) feature >> * of an Ethernet port. >> - * If not NULL, the *rss_key* pointer of the *rss_conf* structure points >> - * to an array holding the RSS key to use for hashing specific header >> - * fields of received packets. The length of this array should be indicated >> - * by *rss_key_len* below. Otherwise, a default random hash key is used by >> - * the device driver. >> - * >> - * The *rss_key_len* field of the *rss_conf* structure indicates the length >> - * in bytes of the array pointed by *rss_key*. To be compatible, this length >> - * will be checked in i40e only. Others assume 40 bytes to be used as before. >> - * >> - * The *rss_hf* field of the *rss_conf* structure indicates the different >> - * types of IPv4/IPv6 packets to which the RSS hashing must be applied. >> - * Supplying an *rss_hf* equal to zero disables the RSS feature. >> */ >> struct rte_eth_rss_conf { >> - uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ >> + /** >> + * In rte_eth_dev_rss_hash_conf_get(), the *rss_key_len* should be >> + * greater than or equal to the hash_key_size which get from >> + * rte_eth_dev_info_get() API. And the *rss_key* should contain at >> least >> + * *rss_key_len* bytes. If not meet these requirements, the query >> result >> + * is unreliable even the operation returns success. >> + * >> + * In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the >> + * *rss_key_len* indicates the length of the *rss_key* in bytes of >> + * the array pointed by *rss_key*. Drivers are free to ignore the >> + * *rss_key_len* and assume key length is 40 bytes. > > In the original comment, it is stated that if no RSS key is given rss_key = NULL , then the PMD selects a random hash key, > Is this behavior changed? Thanks for your comment. Some drivers select a random key, e.g. cpfl_ethdev, bnx2x_vfpf, ena. Some drivers use their default key, which is fixed, e.g. igb. And some just ignore this configuration on rss_key, e.g. cxgbe_ethdev. I will correct that. > >> + */ >> + uint8_t *rss_key; >> uint8_t rss_key_len; /**< hash key length in bytes. */ >> - uint64_t rss_hf; /**< Hash functions to apply - see below. */ >> + /** >> + * Indicates the type of packets or the specific part of packets to >> + * which RSS hashing is to be applied. >> + */ >> + uint64_t rss_hf; >> }; >> >> /* >> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h >> index edefa34c10da..25f1dffd1f30 100644 >> --- a/lib/ethdev/rte_flow.h >> +++ b/lib/ethdev/rte_flow.h >> @@ -3226,6 +3226,7 @@ struct rte_flow_query_count { >> * Hash function types. >> */ >> enum rte_eth_hash_function { >> + /** DEFAULT means driver decides which hash algorithm to pick. */ >> RTE_ETH_HASH_FUNCTION_DEFAULT = 0, >> RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ >> RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ >> -- >> 2.30.0 >