From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AA57A052B; Thu, 30 Jul 2020 20:08:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8F95E07; Thu, 30 Jul 2020 20:08:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E0F1F3B5 for ; Thu, 30 Jul 2020 20:08:31 +0200 (CEST) IronPort-SDR: v/RQo06g+8fFBqCB8LtkGMPbPbOXXyAHr0lSar/x+W/FYMf2HN2t3OqRVYzUxtPBd/cm8Hxjex +b2unNJETfJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="169779068" X-IronPort-AV: E=Sophos;i="5.75,415,1589266800"; d="scan'208";a="169779068" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 11:08:30 -0700 IronPort-SDR: GrD67BO3znPe2KUPqXPx+eFZ2s2FuqMwf7mtte8TYH6b7TQaw1RrjE+uGZLQ1SLjnzmCT4SbhN 38eDnMlJ4R0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,415,1589266800"; d="scan'208";a="272991344" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.212.119.128]) ([10.212.119.128]) by fmsmga007.fm.intel.com with ESMTP; 30 Jul 2020 11:08:30 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman References: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> From: "Kadam, Pallavi" Message-ID: Date: Thu, 30 Jul 2020 11:08:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200620210511.13134-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/7] cmdline: support Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On 6/20/2020 2:05 PM, Dmitry Kozlyuk wrote: > This patchset enables librte_cmdline on Windows. To do that, it creates > a number of wrappers for OS-dependent terminal handling and I/O. > Considered alternative was to revive [1] and use libedit (Unix-only) > for terminal handling. However, testing revealed that WinEditLine [2] > is not a drop-in replacement for libedit, so this solution wouldn't be > universal. > > Note: not all dependency series are up-to-date at the time of > submission, so this version may require hacking to test. > > [1]: http://patchwork.dpdk.org/patch/38561 > [2]: http://mingweditline.sourceforge.net > > --- > Depends-on: series-10512 ("Windows bus/pci support ") > Depends-on: series-10244 ("[v4] eal/windows: ring build on Windows") > Depends-on: series-10282 ("build mempool on Windows ") > Depends-on: series-10382 ("compile librte_net for windows") > > Dmitry Kozlyuk (7): > cmdline: make implementation opaque > cmdline: add internal wrappers for terminal handling > cmdline: add internal wrappers for character input > cmdline: add internal wrapper for vdprintf > eal/windows: improve compatibility networking headers > cmdline: support Windows > examples/cmdline: build on Windows > > app/test-cmdline/commands.c | 8 +- > app/test/test_cmdline_lib.c | 42 ++-- > config/meson.build | 2 + > examples/cmdline/commands.c | 1 - > examples/cmdline/main.c | 1 - > examples/meson.build | 6 +- > lib/librte_cmdline/Makefile | 4 + > lib/librte_cmdline/cmdline.c | 29 +-- > lib/librte_cmdline/cmdline.h | 15 +- > lib/librte_cmdline/cmdline_os_unix.c | 53 +++++ > lib/librte_cmdline/cmdline_os_windows.c | 207 ++++++++++++++++++++ > lib/librte_cmdline/cmdline_parse.c | 4 +- > lib/librte_cmdline/cmdline_private.h | 61 ++++++ > lib/librte_cmdline/cmdline_socket.c | 25 +-- > lib/librte_cmdline/cmdline_vt100.c | 1 - > lib/librte_cmdline/cmdline_vt100.h | 4 + > lib/librte_cmdline/meson.build | 6 + > lib/librte_cmdline/rte_cmdline_version.map | 8 + > lib/librte_eal/windows/include/arpa/inet.h | 30 +++ > lib/librte_eal/windows/include/netinet/in.h | 11 ++ > lib/librte_eal/windows/include/pthread.h | 2 +- > lib/librte_eal/windows/include/sys/socket.h | 24 +++ > lib/meson.build | 1 + > 23 files changed, 470 insertions(+), 75 deletions(-) > create mode 100644 lib/librte_cmdline/cmdline_os_unix.c > create mode 100644 lib/librte_cmdline/cmdline_os_windows.c > create mode 100644 lib/librte_cmdline/cmdline_private.h > create mode 100644 lib/librte_eal/windows/include/arpa/inet.h > create mode 100644 lib/librte_eal/windows/include/sys/socket.h > Will this series be rebased with the latest in order to apply it cleanly? Thanks,