From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EFED7A00C2;
	Mon,  2 May 2022 20:12:07 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A10E040F35;
	Mon,  2 May 2022 20:12:07 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 708DF40E28
 for <dev@dpdk.org>; Mon,  2 May 2022 20:12:06 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 5004EA00C3; Mon,  2 May 2022 20:12:06 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1003] unbalanced braces in header files for extern C
 declarations causing C++ compilation errors
Date: Mon, 02 May 2022 18:12:05 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: swasson@microsoft.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-1003-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=3D1003

            Bug ID: 1003
           Summary: unbalanced braces in header files for extern C
                    declarations causing C++ compilation errors
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: swasson@microsoft.com
  Target Milestone: ---

This was introduced in DPDK 20.11.5.  20.11.4 did not have these issues:

There are a few header files that have multiple extern C declarations, and =
some
of them have unbalanced braces.  This causes C++ compiler errors.

To find them all:

 $ find . -name '*.h'|xargs grep 'extern "C' > foo
 $ find . -name '*.h'|xargs grep 'extern "C'|uniq > bar
 $ diff foo bar
102d101
< ./lib/librte_eventdev/rte_eventdev_pmd.h:extern "C" {
105d103
< ./lib/librte_eventdev/rte_eventdev_pmd_pci.h:extern "C" {
110d107
< ./lib/librte_eventdev/rte_eventdev_pmd_vdev.h:extern "C" {
153d149
< ./lib/librte_ethdev/rte_ethdev_driver.h:extern "C" {

rte_eventdev_pmd.h merely has two nested extern C blocks.

rte_eventdev_pmd_pci.h has two nested extern C blocks, but only one closing
brace at the bottom of the file.

The same is true for rte_ethdev_driver.h and rte_eventdev_pmd_vdev.h.

The latter three cause compilation errors when included from C++ code.

--=20
You are receiving this mail because:
You are the assignee for the bug.=