From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1315A0542; Wed, 26 Oct 2022 16:35:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84A62400D5; Wed, 26 Oct 2022 16:35:57 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 10FC240041 for ; Wed, 26 Oct 2022 16:35:56 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id DDF3CA0544; Wed, 26 Oct 2022 16:35:55 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1115] i40e: RSS hash conf update fails when hash proto mask in rx_adv_conf is 0 Date: Wed, 26 Oct 2022 14:35:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ivan.malov@oktetlabs.ru X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org https://bugs.dpdk.org/show_bug.cgi?id=3D1115 Bug ID: 1115 Summary: i40e: RSS hash conf update fails when hash proto mask in rx_adv_conf is 0 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: ivan.malov@oktetlabs.ru Target Milestone: --- Opensource ethdev tests [1] have been improved over the past weeks. With the latest update, test "usecases/update_rss_hash_conf" finds yet another bug in i40e PMD. If the user has not passed a non-zero hash protocol mask via "rx_adv_conf" during device configure stage, any attempts to use rte_eth_dev_rss_hash_update() at a later stage will fail regardless of hash protocol mask and key being requested. When the test sees that, it tries to re-configure the ethdev, this time with the "rx_adv_conf" hash protocol mask being non-zero. The following invocations of rte_eth_dev_rss_hash_update() do not fail. In this particular case, the "non-zero" mask being used is in fact taken from the "flow_type_rss_offloads" field specified by the PMD. Further research indicates that the PMD considers RSS unconfigured in the case of zero "rx_adv_conf" hash protocol mask, which is not correct. Whether the user wants to enable RSS or not is determined solely by testing RTE_ETH_MQ_RX_RSS_FLAG in "rxmode.mq_mode" field. If this flag is set, rte_eth_dev_rss_hash_update() should not fail unless the application tries a wittingly unsupported configuration. A complete log example can be found at [2]. [1] http://mails.dpdk.org/archives/dev/2022-October/251663.html [2] https://ts-factory.io/bublik/v2/log/163204?focusId=3D163697&mode=3Dtree= Andlog --=20 You are receiving this mail because: You are the assignee for the bug.=