DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1147] ENA NET PMD tracing function enabled on transmit fastpath in non-debug builds
Date: Mon, 12 Dec 2022 10:14:17 +0000	[thread overview]
Message-ID: <bug-1147-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=1147

            Bug ID: 1147
           Summary: ENA NET PMD tracing function enabled on transmit
                    fastpath in non-debug builds
           Product: DPDK
           Version: 21.08
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: declan.doherty@intel.com
  Target Milestone: ---

Created attachment 237
  --> https://bugs.dpdk.org/attachment.cgi?id=237&action=edit
Flamegraph of testpmd and ena pmd on AWS

During performance benchmarking on AWS with VPP, a significant cycle count
increase was noticed within the ENA PMD transmit burst. 

Further investigation with testpmd shows the same cycle count increase, which
is in the order of 10 X compared to pre 21.08 release.

The issues seems to relate to in changes in commit
0a001d69bca086c5a6e62b10552192380efee1f0, which changes the default behaviour
of the  ena_trc_** macros, some of which are on the fast path, to always invoke
rte_log. 

See attach flame graph, for testpmd in mac forward mode, where a huge
percentage of time is spent checking whether to log the trace.

Issue seems to effect all version of DPDK from 21.08 forwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2022-12-12 10:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1147-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).