From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E51A1A034C;
	Mon, 12 Dec 2022 11:14:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 907D64021D;
	Mon, 12 Dec 2022 11:14:19 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 0FF9640151
 for <dev@dpdk.org>; Mon, 12 Dec 2022 11:14:19 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id ED478A0540; Mon, 12 Dec 2022 11:14:18 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1147] ENA NET PMD tracing function enabled on transmit fastpath
 in non-debug builds
Date: Mon, 12 Dec 2022 10:14:17 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 21.08
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: major
X-Bugzilla-Who: declan.doherty@intel.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone attachments.created
Message-ID: <bug-1147-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=3D1147

            Bug ID: 1147
           Summary: ENA NET PMD tracing function enabled on transmit
                    fastpath in non-debug builds
           Product: DPDK
           Version: 21.08
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: declan.doherty@intel.com
  Target Milestone: ---

Created attachment 237
  --> https://bugs.dpdk.org/attachment.cgi?id=3D237&action=3Dedit
Flamegraph of testpmd and ena pmd on AWS

During performance benchmarking on AWS with VPP, a significant cycle count
increase was noticed within the ENA PMD transmit burst.=20

Further investigation with testpmd shows the same cycle count increase, whi=
ch
is in the order of 10 X compared to pre 21.08 release.

The issues seems to relate to in changes in commit
0a001d69bca086c5a6e62b10552192380efee1f0, which changes the default behavio=
ur
of the  ena_trc_** macros, some of which are on the fast path, to always in=
voke
rte_log.=20

See attach flame graph, for testpmd in mac forward mode, where a huge
percentage of time is spent checking whether to log the trace.

Issue seems to effect all version of DPDK from 21.08 forwards.

--=20
You are receiving this mail because:
You are the assignee for the bug.=