DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 121] In ixgbe_tx_free_bufs function the variable free on stack is used before initialization
Date: Fri, 07 Dec 2018 14:55:03 +0000	[thread overview]
Message-ID: <bug-121-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=121

            Bug ID: 121
           Summary: In ixgbe_tx_free_bufs function the variable free on
                    stack is used before initialization
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: valentin.radulescu@enea.com
  Target Milestone: ---

static __rte_always_inline int
ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq)
{
....
    struct rte_mbuf *m, *free[RTE_IXGBE_TX_MAX_FREE_BUF_SZ];
....

       if (nb_free >= RTE_IXGBE_TX_MAX_FREE_BUF_SZ ||
            (nb_free > 0 && m->pool != free[0]->pool)) { <---free[0] is from
the stack
            rte_mempool_put_bulk(free[0]->pool,
                         (void **)free, nb_free);
            nb_free = 0;
        }

        free[nb_free++] = m;  <-- free is set later
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2018-12-07 14:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-121-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).