From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15D7442B21; Tue, 16 May 2023 10:37:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E560140C35; Tue, 16 May 2023 10:37:05 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 9F7E54068E for ; Tue, 16 May 2023 10:37:03 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 9470342B22; Tue, 16 May 2023 10:37:03 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1231] l3fwd: perf reports affected by silently enabling "fast free" Date: Tue, 16 May 2023 08:37:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: examples X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16842262230.FaCdE3E92.3548616 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16842262230.FaCdE3E92.3548616 Date: Tue, 16 May 2023 10:37:03 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1231 Bug ID: 1231 Summary: l3fwd: perf reports affected by silently enabling "fast free" Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: examples Assignee: dev@dpdk.org Reporter: mb@smartsharesystems.com Target Milestone: --- The l3fwd example application is used for benchmarking, including the offic= ial NIC performance reports published on the DPDK web site [1]. A patch to silently enable the "fast free" (RTE_ETH_TX_OFFLOAD_MBUF_FAST_FR= EE) optimization was applied to l3fwd [2][3] in January 2018. This means that the performance reports starting from DPDK 18.02 do not ref= lect generic performance, but the performance of applications that meet the preconditions for using this optimization feature. In order to prevent misleading performance results, such non-generic optimizations should be not be silently enabled; they should be explicitly enabled using a command line option in l3fwd. The same applies to the coming "buffer recycle" optimization. [1]: https://core.dpdk.org/perf-reports/ [2]: http://inbox.dpdk.org/dev/cover.1514280003.git.shahafs@mellanox.com/ [3]: http://git.dpdk.org/dpdk/commit/examples/l3fwd/main.c?id=3D1ef9600b2d200785= 38ca4082f9a4adf2d9bd2ab2 PS: I don't oppose to NIC vendors publishing performance results using non-generic optimizations such as "fast free" or the coming "buffer recycle= ", but it should be fully disclosed which optimizations have been used to achi= eve better results. --=20 You are receiving this mail because: You are the assignee for the bug.= --16842262230.FaCdE3E92.3548616 Date: Tue, 16 May 2023 10:37:03 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1231
Summary l3fwd: perf reports affected by silently enabling "fast = free"
Product DPDK
Version unspecified
Hardware All
OS All
Status UNCONFIRMED
Severity normal
Priority Normal
Component examples
Assignee dev@dpdk.org
Reporter mb@smartsharesystems.com
Target Milestone --- 

The l3fwd example application is u=
sed for benchmarking, including the official
NIC performance reports published on the DPDK web site [1].

A patch to silently enable the "fast free" (RTE_ETH_TX_OFFLOAD_MB=
UF_FAST_FREE)
optimization was applied to l3fwd [2][3] in January 2018.

This means that the performance reports starting from DPDK 18.02 do not ref=
lect
generic performance, but the performance of applications that meet the
preconditions for using this optimization feature.

In order to prevent misleading performance results, such non-generic
optimizations should be not be silently enabled; they should be explicitly
enabled using a command line option in l3fwd.

The same applies to the coming "buffer recycle" optimization.

[1]: https://core.dpdk.org/=
perf-reports/
[2]: http://inbox.dpdk.org/dev/cover.1514280003.git.shahafs@m=
ellanox.com/
[3]:
http://git.dpdk.org/dpdk/commit/exampl=
es/l3fwd/main.c?id=3D1ef9600b2d20078538ca4082f9a4adf2d9bd2ab2

PS: I don't oppose to NIC vendors publishing performance results using
non-generic optimizations such as "fast free" or the coming "=
;buffer recycle",
but it should be fully disclosed which optimizations have been used to achi=
eve
better results.

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --16842262230.FaCdE3E92.3548616--