From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F1E042BC6; Sun, 28 May 2023 12:23:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFAFD40DFB; Sun, 28 May 2023 12:23:05 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 4C29C40A81 for ; Sun, 28 May 2023 12:23:04 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 36BF242BC7; Sun, 28 May 2023 12:23:04 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1239] VMXNET 3 returned the wrong error code in initializing Date: Sun, 28 May 2023 10:23:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: corezeng@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Low X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16852693840.e2f8.1742805 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16852693840.e2f8.1742805 Date: Sun, 28 May 2023 12:23:03 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1239 Bug ID: 1239 Summary: VMXNET 3 returned the wrong error code in initializing Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: Low Component: ethdev Assignee: dev@dpdk.org Reporter: corezeng@gmail.com Target Milestone: --- To call rte_eth_dev_start() to start a device, this function calls the func= tion pointer (dev_start) that was registered by the specific device. rte_eth_dev_start() judges the integer returned from dev_start to continue = or return an error.=20 In the driver of VMXNET 3 the vmxnet3_dev_start is the function that needs = to be registered as dev_start, and it called vmxnet3_dev_rxtx_init().=20 In vmxnet3_dev_rxtx_init(), a wrong error code may be thrown after it invok= es vmxnet3_post_rx_bufs() because it negates the error code before returning i= t*. It causes rte_eth_dev_start() to give a positive number to the invoker, but= it should be a negative number, as described in the comments. *: At vmxnet3_rxtx.c:1318 --=20 You are receiving this mail because: You are the assignee for the bug.= --16852693840.e2f8.1742805 Date: Sun, 28 May 2023 12:23:04 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1239
Summary	VMXNET 3 returned the wrong error code in initializing
Product	DPDK
Version	unspecified
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	minor
Priority	Low
Component	ethdev
Assignee	dev@dpdk.org
Reporter	corezeng@gmail.com
Target Milestone	---

To call rte_eth_dev_start() to sta=
rt a device, this function calls the function
pointer (dev_start) that was registered by the specific device.
rte_eth_dev_start() judges the integer returned from dev_start to continue =
or
return an error.=20

In the driver of VMXNET 3 the vmxnet3_dev_start is the function that needs =
to
be registered as dev_start, and it called vmxnet3_dev_rxtx_init().=20

In vmxnet3_dev_rxtx_init(), a wrong error code may be thrown after it invok=
es
vmxnet3_post_rx_bufs() because it negates the error code before returning i=
t*.
It causes rte_eth_dev_start() to give a positive number to the invoker, but=
 it
should be a negative number, as described in the comments.

*: At vmxnet3_rxtx.c:1318

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --16852693840.e2f8.1742805--