From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 242B04252F; Thu, 7 Sep 2023 05:13:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B74584029E; Thu, 7 Sep 2023 05:13:30 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 444FC4029D for ; Thu, 7 Sep 2023 05:13:29 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 168E042530; Thu, 7 Sep 2023 05:13:29 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1286] cksum Date: Thu, 07 Sep 2023 03:13:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: testpmd X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: wanry@3snic.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16940564080.E8cF9D7c5.2393227 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16940564080.E8cF9D7c5.2393227 Date: Thu, 7 Sep 2023 05:13:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1286 Bug ID: 1286 Summary: cksum Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: testpmd Assignee: dev@dpdk.org Reporter: wanry@3snic.com Target Milestone: --- The code making sure sctp payload be multiple of 4 to determin TX_SCP_CKSUM= in process_inner_cksums() of csumonly.c should convert ipv4_hdr->total_length = to host byte order. The following is the code segment. ``` } else if (info->l4_proto =3D=3D IPPROTO_SCTP) { sctp_hdr =3D (struct rte_sctp_hdr *) ((char *)l3_hdr + info->l3_len); /* sctp payload must be a multiple of 4 to be * offloaded */ if ((tx_offloads & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) && ((ipv4_hdr->total_length & 0x3) =3D=3D 0)) { ol_flags |=3D RTE_MBUF_F_TX_SCTP_CKSUM; } else { sctp_hdr->cksum =3D 0; /* XXX implement CRC32c, example available in * RFC3309 */ } } ``` --=20 You are receiving this mail because: You are the assignee for the bug.= --16940564080.E8cF9D7c5.2393227 Date: Thu, 7 Sep 2023 05:13:28 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1286
Summary	cksum
Product	DPDK
Version	unspecified
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	testpmd
Assignee	dev@dpdk.org
Reporter	wanry@3snic.com
Target Milestone	---

The code making sure sctp payload =
be multiple of 4 to determin TX_SCP_CKSUM in
process_inner_cksums() of csumonly.c should convert ipv4_hdr->total_leng=
th to
host byte order. The following is the code segment.

```
        } else if (info->l4_proto =3D=3D IPPROTO_SCTP) {
                sctp_hdr =3D (struct rte_sctp_hdr *)
                        ((char *)l3_hdr + info->l3_len);
                /* sctp payload must be a multiple of 4 to be
                 * offloaded */
                if ((tx_offloads & RTE_ETH_TX_OFFLOAD_SCTP_CKSUM) &=
&
                        ((ipv4_hdr->total_length & 0x3) =3D=3D 0)) {
                        ol_flags |=3D RTE_MBUF_F_TX_SCTP_CKSUM;
                } else {
                        sctp_hdr->cksum =3D 0;
                        /* XXX implement CRC32c, example available in
                         * RFC3309 */
                }
        }
```

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --16940564080.E8cF9D7c5.2393227--