From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CD9F42606; Thu, 21 Sep 2023 10:43:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 494DC4026D; Thu, 21 Sep 2023 10:43:30 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 112474014F for ; Thu, 21 Sep 2023 10:43:29 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 0096A42607; Thu, 21 Sep 2023 10:43:28 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [Bug 1292] mbuf: L2 packet type names could be improved Date: Thu, 21 Sep 2023 08:43:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: 23.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16952858080.6D3bDfa.2015747 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16952858080.6D3bDfa.2015747 Date: Thu, 21 Sep 2023 10:43:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1292 Bug ID: 1292 Summary: mbuf: L2 packet type names could be improved Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: mb@smartsharesystems.com Target Milestone: --- In rte_mbuf_ptype.h, having both L2 and ETHER in the Ethernet packet type n= ames seems redundant. RTE_PTYPE_L2_ETHER(_TIMESYNC|_ARP|_LLDP, etc.) could simply be RTE_PTYPE_L2(_TIMESYNC|_ARP|_LLDP, etc.). Furthermore, RTE_PTYPE_L2_ETHER defines IP (both v4 and v6) packets, so IP should be part of the name, e.g. RTE_PTYPE_L2_ETHER_IP. --=20 You are receiving this mail because: You are the assignee for the bug.= --16952858080.6D3bDfa.2015747 Date: Thu, 21 Sep 2023 10:43:28 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1292
Summary	mbuf: L2 packet type names could be improved
Product	DPDK
Version	23.11
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	enhancement
Priority	Normal
Component	core
Assignee	dev@dpdk.org
Reporter	mb@smartsharesystems.com
Target Milestone	---

In rte_mbuf_ptype.h, having both L=
2 and ETHER in the Ethernet packet type names
seems redundant.

RTE_PTYPE_L2_ETHER(_TIMESYNC|_ARP|_LLDP, etc.) could simply be
RTE_PTYPE_L2(_TIMESYNC|_ARP|_LLDP, etc.).

Furthermore, RTE_PTYPE_L2_ETHER defines IP (both v4 and v6) packets, so IP
should be part of the name, e.g. RTE_PTYPE_L2_ETHER_IP.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --16952858080.6D3bDfa.2015747--