From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95577432CE; Wed, 8 Nov 2023 04:33:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 828BE42DB2; Wed, 8 Nov 2023 04:33:45 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id DD3A142DB1 for ; Wed, 8 Nov 2023 04:33:44 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id C6FB4432CF; Wed, 8 Nov 2023 04:33:44 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: =?UTF-8?B?W0J1ZyAxMzA4XSBtZXNvbl90ZXN0cy9kcml2ZXLvvJpsaW5rX2Jv?= =?UTF-8?B?bmRpbmdfcnNzY29uZl9hdXRvdGVzdCB0ZXN0IGZhaWxlZA==?= Date: Wed, 08 Nov 2023 03:33:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: meson X-Bugzilla-Version: 23.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: songx.jiale@intel.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=16994144240.bc5Dc.4177390 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --16994144240.bc5Dc.4177390 Date: Wed, 8 Nov 2023 04:33:44 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1308 Bug ID: 1308 Summary: meson_tests/driver=EF=BC=9Alink_bonding_rssconf_autotes= t test failed Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: meson Assignee: dev@dpdk.org Reporter: songx.jiale@intel.com Target Milestone: --- [Environment] DPDK version:=20 dpdk-23.11-rc2: 2bbad8f974e00552d106c27e1d157a31179ab5ec Other software versions: name/version for QEMU, OVS, etc. Repeat as require= d. OS: Ubuntu 22.04.3 LTS/5.15.0-82-generic Compiler: gcc version 11.4.0 Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz NIC hardware: Intel Corporation Ethernet Controller E810-C for SFP [8086:1593] (rev 02) NIC firmware:=20 driver: ice-1.13.0_rc99_4_gb8ad35697 firmware-version: 4.40 0x8001c2f8 1.3492.0 [Test Setup] 1. compile dpdk CC=3Dgcc meson -Denable_kmods=3DFalse -Dlibdir=3Dlib --default-library=3Dst= atic x86_64-native-linuxapp-gcc ninja -C x86_64-native-linuxapp-gcc -j 72 2. blind port to vfio-pci ./usertools/dpdk-devbind.py -b vfio-pci 0000:05:00.0 0000:08:00.0 3. launch dpdk-test /root/dpdk/x86_64-native-linuxapp-gcc/app/dpdk-test -c 0xff --vdev=3Ddma_sk= eleton -a 0000:05:00.0 -a 0000:08:00.0 4. start test=20 RTE>> link_bonding_rssconf_autotest [Show the output from the previous commands.] + ------------------------------------------------------- + + Test Suite : RSS Dynamic Configuration for Bonding Unit Test Suite + ------------------------------------------------------- + + TestCase [ 0] : test_setup succeeded Device with port_id=3D1 already stopped Device with port_id=3D2 already stopped Device with port_id=3D3 already stopped Device with port_id=3D4 already stopped bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 1: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 2: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 3: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 4: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 1: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 2: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 3: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 4: Operation not supported Ethdev port_id=3D1 invalid RSS key len: 40, valid value: 0 EAL: Test assert test_propagate line 383 failed: Cannot set members RSS keys EAL: Test assert test_rss line 467 failed: Propagation test failed Port 1 must be stopped to allow reset Port 2 must be stopped to allow reset Port 3 must be stopped to allow reset Port 4 must be stopped to allow reset + TestCase [ 1] : test_rss failed [Expected Result] + ------------------------------------------------------- + + Test Suite : RSS Dynamic Configuration for Bonding Unit Test Suite + ------------------------------------------------------- + + TestCase [ 0] : test_setup succeeded Device with port_id=3D1 already stopped Device with port_id=3D2 already stopped Device with port_id=3D3 already stopped Device with port_id=3D4 already stopped bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 1: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 2: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 3: Operation not supported bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode = for port 4: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 1: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 2: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 3: Operation not supported bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for port 4: Operation not supported bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated bond_ethdev_rss_hash_update(3208) - rss_key will be truncated [Regression] Is this issue a regression: (Y/N)Y commit bae3cfa520a7205d63752c506d51e832d4944180 Author: Jie Hai Date: Thu Nov 2 16:20:12 2023 +0800 ethdev: clarify RSS related fields usage In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be greater than or equal to the "hash_key_size" which get from rte_eth_dev_info_get() API. And the "rss_key" should contain at least "hash_key_size" bytes. If these requirements are not met, the query unreliable. In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the "rss_key_len" indicates the length of the "rss_key" in bytes of the array pointed by "rss_key", it should be equal to the "hash_key_size" if "rss_key" is not NULL. This patch overwrites the comments of fields of "rte_eth_rss_conf" and "RTE_ETH_HASH_FUNCTION_DEFAULT", checks "rss_key_len" in ethdev level, and documents these changes. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Chengwen Feng Reviewed-by: Ferruh Yigit doc/guides/rel_notes/release_23_11.rst | 5 +++++ lib/ethdev/rte_ethdev.c | 31 +++++++++++++++++++++++++++++++ lib/ethdev/rte_ethdev.h | 33 ++++++++++++++++++------------= --- lib/ethdev/rte_flow.h | 1 + 4 files changed, 55 insertions, 15 deletions --=20 You are receiving this mail because: You are the assignee for the bug.= --16994144240.bc5Dc.4177390 Date: Wed, 8 Nov 2023 04:33:44 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1308
Summary meson_tests/driver=EF=BC=9Alink_bonding_rssconf_autotest test= failed
Product DPDK
Version 23.11
Hardware x86
OS Linux
Status UNCONFIRMED
Severity normal
Priority Normal
Component meson
Assignee dev@dpdk.org
Reporter songx.jiale@intel.com
Target Milestone --- 

[Environment]
DPDK version:=20
dpdk-23.11-rc2: 2bbad8f974e00552d106c27e1d157a31179ab5ec
Other software versions: name/version for QEMU, OVS, etc. Repeat as require=
d.
OS: Ubuntu 22.04.3 LTS/5.15.0-82-generic
Compiler: gcc version 11.4.0
Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
NIC hardware:
Intel Corporation Ethernet Controller E810-C for SFP [8086:1593] (rev 02)
NIC firmware:=20
driver: ice-1.13.0_rc99_4_gb8ad35697
firmware-version: 4.40 0x8001c2f8 1.3492.0

[Test Setup]
1. compile dpdk
CC=3Dgcc meson -Denable_kmods=3DFalse -Dlibdir=3Dlib --default-library=3Dst=
atic
x86_64-native-linuxapp-gcc
ninja -C x86_64-native-linuxapp-gcc -j 72
2. blind port to vfio-pci
./usertools/dpdk-devbind.py -b vfio-pci 0000:05:00.0 0000:08:00.0
3. launch dpdk-test
/root/dpdk/x86_64-native-linuxapp-gcc/app/dpdk-test -c 0xff --vdev=3Ddma_sk=
eleton
-a 0000:05:00.0 -a 0000:08:00.0
4. start test=20
RTE>> link_bonding_rssconf_autotest

[Show the output from the previous commands.]
 + ------------------------------------------------------- +
 + Test Suite : RSS Dynamic Configuration for Bonding Unit Test Suite
 + ------------------------------------------------------- +
 + TestCase [ 0] : test_setup succeeded
Device with port_id=3D1 already stopped
Device with port_id=3D2 already stopped
Device with port_id=3D3 already stopped
Device with port_id=3D4 already stopped
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 1: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 2: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 3: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 4: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 1: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 2: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 3: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 4: Operation not supported
Ethdev port_id=3D1 invalid RSS key len: 40, valid value: 0
EAL: Test assert test_propagate line 383 failed: Cannot set members RSS keys
EAL: Test assert test_rss line 467 failed: Propagation test failed
Port 1 must be stopped to allow reset
Port 2 must be stopped to allow reset
Port 3 must be stopped to allow reset
Port 4 must be stopped to allow reset
 + TestCase [ 1] : test_rss failed

[Expected Result]
 + ------------------------------------------------------- +
 + Test Suite : RSS Dynamic Configuration for Bonding Unit Test Suite
 + ------------------------------------------------------- +
 + TestCase [ 0] : test_setup succeeded
Device with port_id=3D1 already stopped
Device with port_id=3D2 already stopped
Device with port_id=3D3 already stopped
Device with port_id=3D4 already stopped
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 1: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 2: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 3: Operation not supported
bond_ethdev_promiscuous_disable(2751) - Failed to disable promiscuous mode =
for
port 4: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 1: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 2: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 3: Operation not supported
bond_ethdev_allmulticast_disable(2897) - Failed to disable allmulti mode for
port 4: Operation not supported
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated
bond_ethdev_rss_hash_update(3208) - rss_key will be truncated

[Regression]
Is this issue a regression: (Y/N)Y

commit bae3cfa520a7205d63752c506d51e832d4944180
Author: Jie Hai <haijie1@h=
uawei.com>
Date:   Thu Nov 2 16:20:12 2023 +0800

    ethdev: clarify RSS related fields usage

    In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should =
be
    greater than or equal to the "hash_key_size" which get from
    rte_eth_dev_info_get() API. And the "rss_key" should contain =
at
    least "hash_key_size" bytes. If these requirements are not me=
t,
    the query unreliable.

    In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the
    "rss_key_len" indicates the length of the "rss_key"=
 in bytes of
    the array pointed by "rss_key", it should be equal to the
    "hash_key_size" if "rss_key" is not NULL.

    This patch overwrites the comments of fields of "rte_eth_rss_conf&=
quot;
    and "RTE_ETH_HASH_FUNCTION_DEFAULT", checks "rss_key_len=
" in
    ethdev level, and documents these changes.

    Signed-off-by: Jie Hai <ha=
ijie1@huawei.com>
    Acked-by: Huisong Li <li=
huisong@huawei.com>
    Acked-by: Chengwen Feng <fengchengwen@huawei.com>
    Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

 doc/guides/rel_notes/release_23_11.rst |  5 +++++
 lib/ethdev/rte_ethdev.c                | 31 +++++++++++++++++++++++++++++++
 lib/ethdev/rte_ethdev.h                | 33 ++++++++++++++++++------------=
---
 lib/ethdev/rte_flow.h                  |  1 +
 4 files changed, 55 insertions, 15 deletions

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --16994144240.bc5Dc.4177390--