[Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

[Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 6091 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1335

            Bug ID: 1335
           Summary: [dpdk-24.03-rc0] freebsd/nic_uio meson build error
                    with clang16.0.6 and gcc12.2.0 on FreeBSD14
           Product: DPDK
           Version: 23.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: daxuex.gao@intel.com
  Target Milestone: ---

[git]
# git log -1
commit e5dc404d33ac1c6cea5c62a88489746c5cb5e35e (HEAD, origin/main,
origin/HEAD, main)
Author: Stephen Hemminger <stephen@networkplumber.org>
Date:   Mon Dec 11 12:17:32 2023 -0800

    cryptodev: use a dynamic logtype

    The cryptodev logs are all referenced via rte_cryptodev.h,
    so make it dynamic there.

    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    Acked-by: Akhil Goyal <gakhil@marvell.com>

[OS version]
 FreeBSD 14.0-RELEASE
 14.0-RELEASE
 clang version 16.0.6
 gcc version 12.2.0

[bad commit]
 The new freebsd14 found this problem, while the old freebsd13.2 did not.

[Test setup]
CC=clang meson --werror -Denable_kmods=True -Dlibdir=lib -Dexamples=all
--default-library=static x86_64-native-bsd-clang
ninja -j 10 -C x86_64-native-bsd-clang

CC=gcc meson --werror -Denable_kmods=True -Dlibdir=lib -Dexamples=all
--default-library=static x86_64-native-bsdapp-gcc
ninja -j 10 -C x86_64-native-bsd-gcc

[error log]
ninja: Entering directory `x86_64-native-bsdapp-gcc'
[1889/1897] Generating kernel/freebsd/contigmem with a custom command
machine -> /usr/src/sys/amd64/include
x86 -> /usr/src/sys/x86/include
i386 -> /usr/src/sys/i386/include
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/pci/pci_if.m -h
touch opt_global.h
clang  -O2 -pipe -include rte_config.h  -fno-strict-aliasing -Werror -D_KERNEL
-DKLD_MODULE -nostdinc  -I/root/dpdk/x86_64-native-bsdapp-gcc
-I/root/dpdk/config -include
/root/dpdk/x86_64-native-bsdapp-gcc/kernel/freebsd/opt_global.h -I.
-I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common 
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include
-fdebug-prefix-map=./i386=/usr/src/sys/i386/include     -MD 
-MF.depend.contigmem.o -MTcontigmem.o -mcmodel=kernel -mno-red-zone -mno-mmx
-mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
-fstack-protector -Wall -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign
-D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare
-Wno-error=empty-body -Wno-error=parentheses-equality
-Wno-error=unused-function -Wno-error=pointer-sign
-Wno-error=shift-negative-value -Wno-address-of-packed-member
-Wno-format-zero-length   -mno-aes -mno-avx  -std=gnu99 -c
/root/dpdk/kernel/freebsd/contigmem/contigmem.c -o contigmem.o
ld -m elf_x86_64_fbsd -warn-common --build-id=sha1 -T
/usr/src/sys/conf/ldscript.kmod.amd64 -r  -o contigmem.ko contigmem.o
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk contigmem.ko  export_syms | xargs -J%
objcopy % contigmem.ko
objcopy --strip-debug contigmem.ko
[1894/1897] Generating kernel/freebsd/nic_uio with a custom command
FAILED: kernel/freebsd/nic_uio.ko
/usr/bin/make -f ../kernel/freebsd/BSDmakefile.meson KMOD_OBJDIR=kernel/freebsd
KMOD_SRC=../kernel/freebsd/nic_uio/nic_uio.c KMOD=nic_uio
'KMOD_CFLAGS=-I/root/dpdk/x86_64-native-bsdapp-gcc -I/root/dpdk/config -include
rte_config.h' CC=clang
clang  -O2 -pipe -include rte_config.h  -fno-strict-aliasing -Werror -D_KERNEL
-DKLD_MODULE -nostdinc  -I/root/dpdk/x86_64-native-bsdapp-gcc
-I/root/dpdk/config -include
/root/dpdk/x86_64-native-bsdapp-gcc/kernel/freebsd/opt_global.h -I.
-I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common 
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
-fdebug-prefix-map=./machine=/usr/src/sys/amd64/include
-fdebug-prefix-map=./x86=/usr/src/sys/x86/include
-fdebug-prefix-map=./i386=/usr/src/sys/i386/include     -MD 
-MF.depend.nic_uio.o -MTnic_uio.o -mcmodel=kernel -mno-red-zone -mno-mmx
-mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
-fstack-protector -Wall -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign
-D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare
-Wno-error=empty-body -Wno-error=parentheses-equality
-Wno-error=unused-function -Wno-error=pointer-sign
-Wno-error=shift-negative-value -Wno-address-of-packed-member
-Wno-format-zero-length   -mno-aes -mno-avx  -std=gnu99 -c
/root/dpdk/kernel/freebsd/nic_uio/nic_uio.c -o nic_uio.o
/root/dpdk/kernel/freebsd/nic_uio/nic_uio.c:84:81: error: too many arguments
provided to function-like macro invocation
DRIVER_MODULE(nic_uio, pci, nic_uio_driver, nic_uio_devclass, nic_uio_modevent,
0);
                                                                               
^
/usr/src/sys/sys/bus.h:832:9: note: macro 'DRIVER_MODULE' defined here
#define DRIVER_MODULE(name, busname, driver, evh, arg)                  \
        ^
/root/dpdk/kernel/freebsd/nic_uio/nic_uio.c:84:1: error: type specifier
missing, defaults to 'int'; ISO C99 and later do not support implicit int
[-Werror,-Wimplicit-int]
DRIVER_MODULE(nic_uio, pci, nic_uio_driver, nic_uio_devclass, nic_uio_modevent,
0);
^
int
2 errors generated.
*** Error code 1

Stop.
make: stopped in /root/dpdk/x86_64-native-bsdapp-gcc
[1896/1897] Linking target examples/dpdk-vmdq
ninja: build stopped: subcommand failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 8182 bytes --]

Re: [Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

[Stephen Hemminger]

On Tue, 19 Dec 2023 07:46:18 +0000
bugzilla@dpdk.org wrote:

> # git log -1
> commit e5dc404d33ac1c6cea5c62a88489746c5cb5e35e (HEAD, origin/main,
> origin/HEAD, main)
> Author: Stephen Hemminger <stephen@networkplumber.org>
> Date:   Mon Dec 11 12:17:32 2023 -0800
> 
>     cryptodev: use a dynamic logtype
> 
>     The cryptodev logs are all referenced via rte_cryptodev.h,
>     so make it dynamic there.
> 
>     Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>     Acked-by: Akhil Goyal <gakhil@marvell.com>

This patch did not touch the FreeBSD driver, it is a pre-existing condition.

[DPDK/core Bug 1335] [dpdk-24.03-rc0] freebsd/nic_uio meson build error with clang16.0.6 and gcc12.2.0 on FreeBSD14

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1335

Thomas Monjalon (thomas@monjalon.net) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|IN_PROGRESS                 |RESOLVED

--- Comment #4 from Thomas Monjalon (thomas@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=5eedf66ac0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 2751 bytes --]