From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F2B4437B1; Thu, 28 Dec 2023 11:38:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29903402C4; Thu, 28 Dec 2023 11:38:31 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 718D3402BA for ; Thu, 28 Dec 2023 11:38:29 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 58CC8437B2; Thu, 28 Dec 2023 11:38:29 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: =?UTF-8?B?W0J1ZyAxMzM4XSBbZHBkay0yMi4xMS40XSB2aG9zdF92aXJ0aW9f?= =?UTF-8?B?dXNlcl9pbnRlcnJ1cHRfd2l0aF9wb3dlcl9tb25pdG9yL3BlcmZfd2FrZV91?= =?UTF-8?B?cF9zcGxpdF9yaW5nX3Zob3N0X3VzZXJfY29yZV93aXRoX2wzZndkX3Bvd2Vy?= =?UTF-8?B?X3NhbXBsZe+8mnZpcnRpby11c2VyIGNhbid0IHJlY2VpdmUgcGFja2V0?= Date: Thu, 28 Dec 2023 10:38:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: vhost/virtio X-Bugzilla-Version: 22.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: linglix.chen@intel.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17037599090.FDC12a.3867341 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17037599090.FDC12a.3867341 Date: Thu, 28 Dec 2023 11:38:29 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1338 Bug ID: 1338 Summary: [dpdk-22.11.4] vhost_virtio_user_interrupt_with_power_monitor/perf_wa ke_up_split_ring_vhost_user_core_with_l3fwd_power_samp le=EF=BC=9Avirtio-user can't receive packet Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: vhost/virtio Assignee: dev@dpdk.org Reporter: linglix.chen@intel.com Target Milestone: --- [Environment] DPDK version: dpdk 22.11.4-rc3: 4307659a90 OS: Ubuntu 22.04.3 LTS/5.15.0-87-generic Compiler: gcc version 11.4.0 Hardware platform: SPR(Intel(R) Xeon(R) Platinum 8490H) NIC hardware: Ethernet Controller E810-C for QSFP 1592 NIC firmware: 4.40 0x8001c2f1 1.3492.0 NIC kdriver: ice-1.13.3_dirty [Test Setup] Steps to reproduce 1. ssh root@dpdk-yingya-spr2=20=20 Compile DPDK:: meson -Dexamples=3Dl3fwd-power x86_64-native-linuxapp-gcc ninja -C x86_64-native-linuxapp-gcc 2.bind NIC port to vfio-pci,=20=20 ./usertools/dpdk-devbind.py -b vfio-pci 45:00.0 3. Launch virtio-user with server mode::=20 ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 3-4 -n 8 -a 0000:45:00.0 --vdev net_virtio_user0,path=3D./vhost-net,server=3D1,queues=3D1 -- -i --rx= q=3D1 --txq=3D1 4. Launch vhost with l3fwd-power::=20=20=20=20=20=20 ./x86_64-native-linuxapp-gcc/examples/dpdk-l3fwd-power -l 5-6 -n 8=20=20 --file-prefix=3Dl3fwd-pwd_216146_20231228175051 --no-pci --vdev net_vhost0,iface=3D./vhost-net,queues=3D1,client=3D1 --log-level=3D'user= 1,7' -- -p 1 --config=3D'(0,0,5)' --parse-ptype --pmd-mgmt=3Dmonitor 5. Start virtio-user:: testpmd>start 6. Sent imix packets from TG [Show the output from the previous commands] pktgen: ixia packet generator: run traffic 5s to warm up ... pktgen: begin traffic ...... tester: scp -v ixiaConfig.tcl root@dpdk-yingya-spr2= :~/ pktgen: source ixiaConfig.tcl pktgen: ixStopTransmit portList pktgen: traffic completed. pktgen: begin traffic ...... tester: scp -v ixiaConfig.tcl root@dpdk-yingya-spr2= :~/ pktgen: source ixiaConfig.tcl pktgen: begin get port statistic ... pktgen: stat getRate statAllStats 1 3 4 pktgen: stat cget -framesReceived pktgen: stat cget -bitsReceived pktgen: stat cget -oversize pktgen: throughput: pps_rx 0.000000, bps_rx 0.000000 [Expected Result] check packets can fwd back with correct payload. Regression Is this issue a regression: (Y/N) Y test on SPR only The commit a07736eb68 will build failed 8c291d8778 tested failed (vhost: fix checking virtqueue access in stats API= )=20=20=20=20 a07736eb68 build failed (vhost: fix missing lock protection in power monitor API) (/lib/vhost/vhost.c:2171:13: error: unused variable =E2=80=98ret=E2=80= =99 [-Werror=3Dunused-variable]) adae353b36 tested passed (vhost: fix check on virtqueue access in in-flight getter)=20=20=20=20=20 bad commit 8c291d87783d2e22e6234cddc23bee27d0f14dae (HEAD -> 22.11) Author: Maxime Coquelin Date: Fri Oct 20 10:48:04 2023 +0200 vhost: fix checking virtqueue access in stats API [ upstream commit a004501a147889d608008ab6f18355e9b0ceff65 ] Acquiring the access lock is not enough to ensure virtqueue's metadata such as vring pointers are valid. The access status must also be checked. Fixes: be75dc99ea1f ("vhost: support per-virtqueue statistics") Signed-off-by: Maxime Coquelin Acked-by: David Marchand --=20 You are receiving this mail because: You are the assignee for the bug.= --17037599090.FDC12a.3867341 Date: Thu, 28 Dec 2023 11:38:29 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1338
Summary [dpdk-22.11.4] vhost_virtio_user_interrupt_with_power_monitor= /perf_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample=EF=BC=9Avi= rtio-user can't receive packet
Product DPDK
Version 22.11
Hardware All
OS All
Status UNCONFIRMED
Severity normal
Priority Normal
Component vhost/virtio
Assignee dev@dpdk.org
Reporter linglix.chen@intel.com
Target Milestone --- 

[Environment]
DPDK version: dpdk 22.11.4-rc3: 4307659a90
OS: Ubuntu 22.04.3 LTS/5.15.0-87-generic
Compiler: gcc version 11.4.0
Hardware platform: SPR(Intel(R) Xeon(R) Platinum 8490H)
NIC hardware: Ethernet Controller E810-C for QSFP 1592
NIC firmware: 4.40 0x8001c2f1 1.3492.0
NIC kdriver: ice-1.13.3_dirty

[Test Setup]
Steps to reproduce
1. ssh root@dpdk-yingya-spr2=20=20
Compile DPDK::
meson  -Dexamples=3Dl3fwd-power x86_64-native-linuxapp-gcc
ninja -C x86_64-native-linuxapp-gcc

2.bind NIC port to vfio-pci,=20=20
./usertools/dpdk-devbind.py -b vfio-pci 45:00.0

3. Launch virtio-user with server mode::=20
./x86_64-native-linuxapp-gcc/app/dpdk-testpmd  -l 3-4 -n 8 -a 0000:45:00.0
--vdev net_virtio_user0,path=3D./vhost-net,server=3D1,queues=3D1 -- -i --rx=
q=3D1
--txq=3D1

4. Launch vhost with l3fwd-power::=20=20=20=20=20=20
 ./x86_64-native-linuxapp-gcc/examples/dpdk-l3fwd-power  -l 5-6 -n 8=20=20
--file-prefix=3Dl3fwd-pwd_216146_20231228175051 --no-pci --vdev
net_vhost0,iface=3D./vhost-net,queues=3D1,client=3D1    --log-level=3D'user=
1,7' -- -p 1
 --config=3D'(0,0,5)' --parse-ptype --pmd-mgmt=3Dmonitor

5. Start virtio-user::
      testpmd>start

6. Sent imix packets from TG

[Show the output from the previous commands]
pktgen: ixia packet generator: run traffic 5s to warm up ...
                        pktgen: begin traffic ......
                        tester: scp -v ixiaConfig.tcl root@dpdk-yingya-=
spr2:~/
                        pktgen: source ixiaConfig.tcl
                        pktgen: ixStopTransmit portList
                        pktgen: traffic completed.
                        pktgen: begin traffic ......
                        tester: scp -v ixiaConfig.tcl root@dpdk-yingya-=
spr2:~/
                        pktgen: source ixiaConfig.tcl
                        pktgen: begin get port statistic ...
                        pktgen: stat getRate statAllStats 1 3 4
                        pktgen: stat cget -framesReceived
                        pktgen: stat cget -bitsReceived
                        pktgen: stat cget -oversize
                        pktgen: throughput: pps_rx 0.000000, bps_rx 0.000000

[Expected Result]
 check packets can fwd back with correct payload.

Regression
Is this issue a regression: (Y/N) Y
test on SPR only
The commit a07736eb68 will build failed
8c291d8778 tested failed (vhost: fix checking virtqueue access in stats API=
)=20=20=20=20
a07736eb68 build failed (vhost: fix missing lock protection in power monitor
API) (/lib/vhost/vhost.c:2171:13: error: unused variable =E2=80=98ret=E2=80=
=99
[-Werror=3Dunused-variable])
adae353b36 tested passed (vhost: fix check on virtqueue access in in-flight
getter)=20=20=20=20=20

bad commit  8c291d87783d2e22e6234cddc23bee27d0f14dae (HEAD -> 22.11)
Author: Maxime Coquelin <maxime.coquelin@redhat.com>
Date:   Fri Oct 20 10:48:04 2023 +0200

    vhost: fix checking virtqueue access in stats API

    [ upstream commit a004501a147889d608008ab6f18355e9b0ceff65 ]

    Acquiring the access lock is not enough to ensure
    virtqueue's metadata such as vring pointers are valid.

    The access status must also be checked.

    Fixes: be75dc99ea1f ("vhost: support per-virtqueue statistics"=
;)

    Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
    Acked-by: David Marchand <david.marchand@redhat.com>

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17037599090.FDC12a.3867341--