From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95B5543CB2; Thu, 14 Mar 2024 11:12:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B74F406BC; Thu, 14 Mar 2024 11:12:00 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id C8A8040297 for ; Thu, 14 Mar 2024 11:11:58 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id B3FA043CB3; Thu, 14 Mar 2024 11:11:58 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/other Bug 1402] net/ice: vlan stripping is broken Date: Thu, 14 Mar 2024 10:11:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: other X-Bugzilla-Version: 23.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: david.marchand@redhat.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17104111180.03436CE.7431 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17104111180.03436CE.7431 Date: Thu, 14 Mar 2024 11:11:58 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1402 Bug ID: 1402 Summary: net/ice: vlan stripping is broken Product: DPDK Version: 23.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: david.marchand@redhat.com Target Milestone: --- Following de5da9d16430 ("net/ice: support double VLAN"), "single" vlan stripping is broken with net/ice devices. This was reported on the users@ mailing list. https://inbox.dpdk.org/users/CAJFAV8xvLmPrdVMyhBm0daCLcpG47D0z6vFMzjhjdKbLe= rFKuw@mail.gmail.com/T/#t Basically, vlan does not get stripped and the vlan tci is not put in mbuf metadata: With v24.03-rc2: # ./build/app/dpdk-testpmd -a 0000:04:00.0 -- --enable-hw-vlan-strip -i ... ice_load_pkg_type(): Active package is: 1.3.30.0, ICE OS Default Package (double VLAN mode) ... testpmd> set verbose 1 Change verbose level from 0 to 1 testpmd> start ... port 0/queue 0: received 1 packets src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 - type=3D0x8100 - length=3D60 - nb_segs=3D1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER_VLAN L3_IPV4 - l2_len=3D18 - l3_len=3D20 - Receive queue=3D0x0 ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD After reverting the commit: port 0/queue 0: received 1 packets src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 - type=3D0x0800 - length=3D60 - nb_segs=3D1 - VLAN tci=3D0x2a - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG - sw ptype: L2_ETHER L3_IPV4 - l2_len=3D14 - l3_len=3D20 - Receive queue=3D0x0 ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD --=20 You are receiving this mail because: You are the assignee for the bug.= --17104111180.03436CE.7431 Date: Thu, 14 Mar 2024 11:11:58 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1402
Summary net/ice: vlan stripping is broken
Product DPDK
Version 23.07
Hardware All
OS All
Status UNCONFIRMED
Severity normal
Priority Normal
Component other
Assignee dev@dpdk.org
Reporter david.marchand@redhat.com
Target Milestone --- 

Following de5da9d16430 ("net/=
ice: support double VLAN"), "single" vlan
stripping is broken with net/ice devices.

This was reported on the users@ mailing list.

https://inbox.dpdk.org/users/CAJF=
AV8xvLmPrdVMyhBm0daCLcpG47D0z6vFMzjhjdKbLerFKuw@mail.gmail.com/T/#t


Basically, vlan does not get stripped and the vlan tci is not put in mbuf
metadata:

With v24.03-rc2:

# ./build/app/dpdk-testpmd -a 0000:04:00.0 -- --enable-hw-vlan-strip -i
...
ice_load_pkg_type(): Active package is: 1.3.30.0, ICE OS Default
Package (double VLAN mode)
...
testpmd> set verbose 1
Change verbose level from 0 to 1
testpmd> start
...
port 0/queue 0: received 1 packets
  src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 -
type=3D0x8100 - length=3D60 - nb_segs=3D1 - hw ptype: L2_ETHER
L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER_VLAN L3_IPV4  -
l2_len=3D18 - l3_len=3D20 - Receive queue=3D0x0
  ol_flags: RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD
RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD


After reverting the commit:

port 0/queue 0: received 1 packets
  src=3D00:00:00:00:00:00 - dst=3DFF:FF:FF:FF:FF:FF - pool=3Dmb_pool_0 -
type=3D0x0800 - length=3D60 - nb_segs=3D1 - VLAN tci=3D0x2a - hw ptype:
L2_ETHER L3_IPV4_EXT_UNKNOWN L4_NONFRAG  - sw ptype: L2_ETHER L3_IPV4
- l2_len=3D14 - l3_len=3D20 - Receive queue=3D0x0
  ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD
RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED
RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17104111180.03436CE.7431--