From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D97EC44111; Thu, 30 May 2024 16:28:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 839C540DC9; Thu, 30 May 2024 16:28:49 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id D393840A7F for ; Thu, 30 May 2024 16:28:48 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id BB6BE44113; Thu, 30 May 2024 16:28:48 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1448] cannot disable RTE_ETHDEV_RXTX_CALLBACKS from rte_config.h Date: Thu, 30 May 2024 14:28:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: INVALID X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17170793281.bC0fAFCb.3209117 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17170793281.bC0fAFCb.3209117 Date: Thu, 30 May 2024 16:28:48 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1448 Morten Br=C3=B8rup (mb@smartsharesystems.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|CONFIRMED |RESOLVED --- Comment #3 from Morten Br=C3=B8rup (mb@smartsharesystems.com) --- The config/rte_config.h source code configuration is for exotic configurati= on parameters that we don't want to expose to Meson. The threshold between normal and exotic is not well defined. :-) The bug report says that ethdev rx/tx callbacks cannot be disabled in config/rte_config.h, where it is configurable. This is not correct. They ca= n be disabled in config/rte_config.h, so there is no bug; the bug reporter just didn't know how to do it. Although I personally prefer #if over #ifdef, it would be a huge patch seri= es to replace all occurrences of #ifdef XYZ with #if XYZ. (2800+ LOC containing '#ifdef': grep -r '#ifdef' | grep -v '__cplusplus' | wc) --=20 You are receiving this mail because: You are the assignee for the bug.= --17170793281.bC0fAFCb.3209117 Date: Thu, 30 May 2024 16:28:48 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Morten Br=C3=B8rup changed bug 1448

What	Removed	Added
Resolution	---	INVALID
Status	CONFIRMED	RESOLVED

Comment # 3 on bug 1448 from Morten Br=C3=B8rup

The config/rte_config.h source cod=
e configuration is for exotic configuration
parameters that we don't want to expose to Meson.

The threshold between normal and exotic is not well defined. :-)

The bug report says that ethdev rx/tx callbacks cannot be disabled in
config/rte_config.h, where it is configurable. This is not correct. They ca=
n be
disabled in config/rte_config.h, so there is no bug; the bug reporter just
didn't know how to do it.

Although I personally prefer #if over #ifdef, it would be a huge patch seri=
es
to replace all occurrences of #ifdef XYZ with #if XYZ. (2800+ LOC containing
'#ifdef': grep -r '#ifdef' | grep -v '__cplusplus' | wc)

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17170793281.bC0fAFCb.3209117--