DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/core Bug 1450] Regression: vdev device not setup in secondary process
Date: Fri, 31 May 2024 17:27:44 +0000	[thread overview]
Message-ID: <bug-1450-3@http.bugs.dpdk.org/> (raw)

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1450

            Bug ID: 1450
           Summary: Regression: vdev device not setup in secondary process
           Product: DPDK
           Version: 24.03
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

If I run testpmd as primary and dumpcap as secondary process with a vdev (null,
tap, etc). The the vdev device is not setup in the secondary process.

Example:
# ./build/app/dpdk-dumpcap  -D
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_51860_420642a7f63
vdev_action(): failed to add vdev, net_null0




This works with 23.11 and earlier releases and is a regression.
Not only is this a regression bug, it shows a short coming in the CI system for
not catching it.

Bisection reveals the commit causing the regression is:

commit 6666628362c94a0b567a39a0177539c12c97d999
Author: Mingjin Ye <mingjinx.ye@intel.com>
Date:   Fri Sep 1 07:24:09 2023 +0000

    bus/vdev: fix devargs in secondary process

    When a device is created by a secondary process, an empty devargs is
    temporarily generated and bound to it. This causes the device to not
    be associated with the correct devargs, and the empty devargs are not
    released when the resource is freed.

    This patch fixes the issue by matching the devargs when inserting a
    device in secondary process.

    Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
    Fixes: a16040453968 ("eal: extract vdev infra")
    Cc: stable@dpdk.org

    Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
    Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 4148 bytes --]

                 reply	other threads:[~2024-05-31 17:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1450-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).