From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BA1D4411E; Fri, 31 May 2024 19:27:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DB1240DCB; Fri, 31 May 2024 19:27:46 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 7AD8440C35 for ; Fri, 31 May 2024 19:27:44 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 718304411F; Fri, 31 May 2024 19:27:44 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/core Bug 1450] Regression: vdev device not setup in secondary process Date: Fri, 31 May 2024 17:27:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: 24.03 X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: stephen@networkplumber.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17171764640.6EA49.3757764 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17171764640.6EA49.3757764 Date: Fri, 31 May 2024 19:27:44 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1450 Bug ID: 1450 Summary: Regression: vdev device not setup in secondary process Product: DPDK Version: 24.03 Hardware: All OS: Linux Status: UNCONFIRMED Severity: major Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: stephen@networkplumber.org Target Milestone: --- If I run testpmd as primary and dumpcap as secondary process with a vdev (n= ull, tap, etc). The the vdev device is not setup in the secondary process. Example: # ./build/app/dpdk-dumpcap -D EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_51860_420642a7f63 vdev_action(): failed to add vdev, net_null0 This works with 23.11 and earlier releases and is a regression. Not only is this a regression bug, it shows a short coming in the CI system= for not catching it. Bisection reveals the commit causing the regression is: commit 6666628362c94a0b567a39a0177539c12c97d999 Author: Mingjin Ye Date: Fri Sep 1 07:24:09 2023 +0000 bus/vdev: fix devargs in secondary process When a device is created by a secondary process, an empty devargs is temporarily generated and bound to it. This causes the device to not be associated with the correct devargs, and the empty devargs are not released when the resource is freed. This patch fixes the issue by matching the devargs when inserting a device in secondary process. Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") Fixes: a16040453968 ("eal: extract vdev infra") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye Acked-by: Anatoly Burakov --=20 You are receiving this mail because: You are the assignee for the bug.= --17171764640.6EA49.3757764 Date: Fri, 31 May 2024 19:27:44 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1450
Summary Regression: vdev device not setup in secondary process
Product DPDK
Version 24.03
Hardware All
OS Linux
Status UNCONFIRMED
Severity major
Priority Normal
Component core
Assignee dev@dpdk.org
Reporter stephen@networkplumber.org
Target Milestone --- 

If I run testpmd as primary and du=
mpcap as secondary process with a vdev (null,
tap, etc). The the vdev device is not setup in the secondary process.

Example:
# ./build/app/dpdk-dumpcap  -D
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_51860_420642a7f63
vdev_action(): failed to add vdev, net_null0




This works with 23.11 and earlier releases and is a regression.
Not only is this a regression bug, it shows a short coming in the CI system=
 for
not catching it.

Bisection reveals the commit causing the regression is:

commit 6666628362c94a0b567a39a0177539c12c97d999
Author: Mingjin Ye <mingjin=
x.ye@intel.com>
Date:   Fri Sep 1 07:24:09 2023 +0000

    bus/vdev: fix devargs in secondary process

    When a device is created by a secondary process, an empty devargs is
    temporarily generated and bound to it. This causes the device to not
    be associated with the correct devargs, and the empty devargs are not
    released when the resource is freed.

    This patch fixes the issue by matching the devargs when inserting a
    device in secondary process.

    Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct=
")
    Fixes: a16040453968 ("eal: extract vdev infra")
    Cc: stable@dpdk.org

    Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
    Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17171764640.6EA49.3757764--