From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F5304548C; Tue, 18 Jun 2024 12:20:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DC5140DD5; Tue, 18 Jun 2024 12:20:01 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 06F7140684 for ; Tue, 18 Jun 2024 12:20:00 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id DCF954548D; Tue, 18 Jun 2024 12:19:59 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/vhost/virtio Bug 1463] disable vhost guest notification not work when split queue and VIRTIO_RING_F_EVENT_IDX negotiated Date: Tue, 18 Jun 2024 10:19:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: vhost/virtio X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: topchenfu@qq.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17187059990.5fda9e.2389095 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17187059990.5fda9e.2389095 Date: Tue, 18 Jun 2024 12:19:59 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1463 Bug ID: 1463 Summary: disable vhost guest notification not work when split queue and VIRTIO_RING_F_EVENT_IDX negotiated Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: vhost/virtio Assignee: dev@dpdk.org Reporter: topchenfu@qq.com Target Milestone: --- in `lib/vhost/vhost.c`: ``` static inline int vhost_enable_notify_split(struct virtio_net *dev, struct vhost_virtqueue *vq, int enable) { if (vq->used =3D=3D NULL) return -1; if (!(dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX))) { if (enable) vq->used->flags &=3D ~VRING_USED_F_NO_NOTIFY; else vq->used->flags |=3D VRING_USED_F_NO_NOTIFY; } else { if (enable) vhost_avail_event(vq) =3D vq->last_avail_idx; } return 0; } ``` when enable=3D0, this function do nothing when VIRTIO_RING_F_EVENT_IDX negotiated, casued the guest do unnecessary kicks when sending & receiving. it is a bug or feature? --=20 You are receiving this mail because: You are the assignee for the bug.= --17187059990.5fda9e.2389095 Date: Tue, 18 Jun 2024 12:19:59 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1463
Summary disable vhost guest notification not work when split queue an= d VIRTIO_RING_F_EVENT_IDX negotiated
Product DPDK
Version unspecified
Hardware x86
OS Linux
Status UNCONFIRMED
Severity normal
Priority Normal
Component vhost/virtio
Assignee dev@dpdk.org
Reporter topchenfu@qq.com
Target Milestone --- 

in `lib/vhost/vhost.c`:

```
static inline int
vhost_enable_notify_split(struct virtio_net *dev,
                struct vhost_virtqueue *vq, int enable)
{
        if (vq->used =3D=3D NULL)
                return -1;

        if (!(dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX=
))) {
                if (enable)
                        vq->used->flags &=3D ~VRING_USED_F_NO_NOT=
IFY;
                else
                        vq->used->flags |=3D VRING_USED_F_NO_NOTIFY;
        } else {
                if (enable)
                        vhost_avail_event(vq) =3D vq->last_avail_idx;
        }
        return 0;
}
```

when enable=3D0, this function do nothing when VIRTIO_RING_F_EVENT_IDX
negotiated, casued the guest do unnecessary kicks when sending & receiv=
ing.

it is a bug or feature?

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17187059990.5fda9e.2389095--