[DPDK/core Bug 1471] rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG

[DPDK/core Bug 1471] rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1471

            Bug ID: 1471
           Summary: rte_pktmbuf_free_bulk does not respect
                    RTE_LIBRTE_MBUF_DEBUG
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: mb@smartsharesystems.com
  Target Milestone: ---

rte_pktmbuf_free_bulk() calls __rte_mbuf_sanity_check(), which behaves
differently depending on RTE_LIBRTE_MBUF_DEBUG being defined or not.

Unfortunately, rte_pktmbuf_free_bulk() is not inline, but in the C file.
This means that the behavior of __rte_mbuf_sanity_check() within
rte_pktmbuf_free_bulk() is controlled by the RTE_LIBRTE_MBUF_DEBUG setting when
building the DPDK library, not when building the application.

rte_pktmbuf_free_bulk() should have been inline in the header file, so the
application developer can control its __rte_mbuf_sanity_check() behavior by
using RTE_LIBRTE_MBUF_DEBUG setting when building the application.

How to remove this function from the ABI and make it inline instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3174 bytes --]

[DPDK/core Bug 1471] Some rte_pktmbuf functions do not respect RTE_LIBRTE_MBUF_DEBUG

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1471

Morten Brørup (mb@smartsharesystems.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Morten Brørup (mb@smartsharesystems.com) ---
I tend to agree with you on this.

Although older versions of the mbuf library didn't have this restriction for
RTE_LIBRTE_MBUF_DEBUG (which was only used in the header file, and thus
controllable for the application build), RTE_LIBRTE_MEMPOOL_DEBUG works as you
describe, so the same could be reasonably assumed about RTE_LIBRTE_MBUF_DEBUG.

Let's not consider it a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 2941 bytes --]