From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21CF3454BE; Fri, 21 Jun 2024 20:33:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12A1D4027D; Fri, 21 Jun 2024 20:33:07 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 875C640265 for ; Fri, 21 Jun 2024 20:33:05 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id 7293B454BF; Fri, 21 Jun 2024 20:33:05 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/core Bug 1471] rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG Date: Fri, 21 Jun 2024 18:33:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17189947850.fD4ADF0fd.3241245 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17189947850.fD4ADF0fd.3241245 Date: Fri, 21 Jun 2024 20:33:05 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1471 Bug ID: 1471 Summary: rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: mb@smartsharesystems.com Target Milestone: --- rte_pktmbuf_free_bulk() calls __rte_mbuf_sanity_check(), which behaves differently depending on RTE_LIBRTE_MBUF_DEBUG being defined or not. Unfortunately, rte_pktmbuf_free_bulk() is not inline, but in the C file. This means that the behavior of __rte_mbuf_sanity_check() within rte_pktmbuf_free_bulk() is controlled by the RTE_LIBRTE_MBUF_DEBUG setting = when building the DPDK library, not when building the application. rte_pktmbuf_free_bulk() should have been inline in the header file, so the application developer can control its __rte_mbuf_sanity_check() behavior by using RTE_LIBRTE_MBUF_DEBUG setting when building the application. How to remove this function from the ABI and make it inline instead? --=20 You are receiving this mail because: You are the assignee for the bug.= --17189947850.fD4ADF0fd.3241245 Date: Fri, 21 Jun 2024 20:33:05 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All

Bug ID	1471
Summary	rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG
Product	DPDK
Version	unspecified
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	core
Assignee	dev@dpdk.org
Reporter	mb@smartsharesystems.com
Target Milestone	---

rte_pktmbuf_free_bulk() calls __rt=
e_mbuf_sanity_check(), which behaves
differently depending on RTE_LIBRTE_MBUF_DEBUG being defined or not.

Unfortunately, rte_pktmbuf_free_bulk() is not inline, but in the C file.
This means that the behavior of __rte_mbuf_sanity_check() within
rte_pktmbuf_free_bulk() is controlled by the RTE_LIBRTE_MBUF_DEBUG setting =
when
building the DPDK library, not when building the application.

rte_pktmbuf_free_bulk() should have been inline in the header file, so the
application developer can control its __rte_mbuf_sanity_check() behavior by
using RTE_LIBRTE_MBUF_DEBUG setting when building the application.

How to remove this function from the ABI and make it inline instead?

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17189947850.fD4ADF0fd.3241245-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 098FA454BE; Fri, 21 Jun 2024 21:03:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED5AE4027D; Fri, 21 Jun 2024 21:03:57 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id B44C540265 for ; Fri, 21 Jun 2024 21:03:56 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id A7162454BF; Fri, 21 Jun 2024 21:03:56 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/core Bug 1471] Some rte_pktmbuf functions do not respect RTE_LIBRTE_MBUF_DEBUG Date: Fri, 21 Jun 2024 19:03:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: INVALID X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: multipart/alternative; boundary=17189966360.e2B4AbCd.3247339 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17189966360.e2B4AbCd.3247339 Date: Fri, 21 Jun 2024 21:03:56 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1471 Morten Br=C3=B8rup (mb@smartsharesystems.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #3 from Morten Br=C3=B8rup (mb@smartsharesystems.com) --- I tend to agree with you on this. Although older versions of the mbuf library didn't have this restriction for RTE_LIBRTE_MBUF_DEBUG (which was only used in the header file, and thus controllable for the application build), RTE_LIBRTE_MEMPOOL_DEBUG works as = you describe, so the same could be reasonably assumed about RTE_LIBRTE_MBUF_DEB= UG. Let's not consider it a bug. --=20 You are receiving this mail because: You are the assignee for the bug.= --17189966360.e2B4AbCd.3247339 Date: Fri, 21 Jun 2024 21:03:56 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All Morten Br=C3=B8rup changed bug 1471

What	Removed	Added
Status	UNCONFIRMED	RESOLVED
Resolution	---	INVALID

Comment # 3 on bug 1471 from Morten Br=C3=B8rup

I tend to agree with you on this.

Although older versions of the mbuf library didn't have this restriction for
RTE_LIBRTE_MBUF_DEBUG (which was only used in the header file, and thus
controllable for the application build), RTE_LIBRTE_MEMPOOL_DEBUG works as =
you
describe, so the same could be reasonably assumed about RTE_LIBRTE_MBUF_DEB=
UG.

Let's not consider it a bug.

You are receiving this mail because:

You are the assignee for the bug.

=20=20=20=20=20=20=20=20=20=20

= --17189966360.e2B4AbCd.3247339--