[DPDK/core Bug 1499] Intel uncore power library fails because of too many frequencies

[DPDK/core Bug 1499] Intel uncore power library fails because of too many frequencies

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1499

            Bug ID: 1499
           Summary: Intel uncore power library fails because of too many
                    frequencies
           Product: DPDK
           Version: 24.07
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

Running 24.07-rc2 on Intel core box fails the power uncore test because:

RTE>>power_intel_uncore_autotest
POWER: Too many available uncore frequencies: 33
POWER: Cannot get available uncore frequencies of pkg 00 die 00
Cannot initialise uncore power management for pkg 0 die 0, this may occur if
environment is not configured correctly(APCI cpufreq) or operating in another
valid Power management environment


The CPU is: 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
initial_max_freq_khz:3600000
initial_min_freq_khz:400000
max_freq_khz:3600000
min_freq_khz:400000

Which leads to this expression:
        num_uncore_freqs = (ui->init_max_freq - ui->init_min_freq) / BUS_FREQ +
1;
        if (num_uncore_freqs >= MAX_UNCORE_FREQS) {
                POWER_LOG(ERR, "Too many available uncore frequencies: %d",
                                num_uncore_freqs);

I.e:
        num_uncore_freqs = (3600000 - 400000) / 100000 + 1
                         = 33

Looks like an off-by-one error, was this ever tested?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3528 bytes --]

[DPDK/core Bug 1499] Intel uncore power library fails because of too many frequencies

[bugzilla]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1499

Thomas Monjalon (thomas@monjalon.net) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Thomas Monjalon (thomas@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=93db1cfcc3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 2661 bytes --]