From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1544] rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum incorrect
Date: Mon, 16 Sep 2024 13:35:15 +0000 [thread overview]
Message-ID: <bug-1544-3@http.bugs.dpdk.org/> (raw)
[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]
https://bugs.dpdk.org/show_bug.cgi?id=1544
Bug ID: 1544
Summary: rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum
incorrect
Product: DPDK
Version: 24.07
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: mb@smartsharesystems.com
Target Milestone: ---
rte_eth_dev_adjust_nb_rx_tx_desc() does not consider tx_rs_thresh and
tx_free_thresh when adjusting nb_tx_desc for minimum allowed TX descriptors.
E.g. the IXGBE driver reports:
dev_info.tx_desc_lim.nb_min = 32.
dev_info.default_txconf.tx_rs_thresh = 32.
dev_info.default_txconf.tx_free_thresh = 32.
If calling rte_eth_dev_adjust_nb_rx_tx_desc() with nb_tx_desc = 32, it will
adjust to nb_tx_desc = 32.
But then rte_eth_tx_queue_setup() will fail afterwards, because it needs
nb_tx_desc >= tx_rs_thresh + tx_free_thresh.
Suggested fix:
Under all circumstances, rte_eth_dev_adjust_nb_rx_tx_desc() should take
tx_rs_thresh and tx_free_thresh into consideration when adjusting nb_tx_desc
for minimum allowed.
Preferably, it should take an optional "const struct rte_eth_txconf *tx_conf"
parameter, like rte_eth_tx_queue_setup(), or it can use the tx_rs_thresh and
tx_free_thresh values from default_txconf.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #2: Type: text/html, Size: 3393 bytes --]
reply other threads:[~2024-09-16 13:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1544-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).