From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C911459AE; Mon, 16 Sep 2024 15:35:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AC394025F; Mon, 16 Sep 2024 15:35:17 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 0E57C40150 for ; Mon, 16 Sep 2024 15:35:16 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id EE72E459AF; Mon, 16 Sep 2024 15:35:15 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1544] rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum incorrect Date: Mon, 16 Sep 2024 13:35:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.07 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mb@smartsharesystems.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17264937150.A4ecabc7b.1362663 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17264937150.A4ecabc7b.1362663 Date: Mon, 16 Sep 2024 15:35:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1544 Bug ID: 1544 Summary: rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum incorrect Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: mb@smartsharesystems.com Target Milestone: --- rte_eth_dev_adjust_nb_rx_tx_desc() does not consider tx_rs_thresh and tx_free_thresh when adjusting nb_tx_desc for minimum allowed TX descriptors. E.g. the IXGBE driver reports: dev_info.tx_desc_lim.nb_min =3D 32. dev_info.default_txconf.tx_rs_thresh =3D 32. dev_info.default_txconf.tx_free_thresh =3D 32. If calling rte_eth_dev_adjust_nb_rx_tx_desc() with nb_tx_desc =3D 32, it wi= ll adjust to nb_tx_desc =3D 32. But then rte_eth_tx_queue_setup() will fail afterwards, because it needs nb_tx_desc >=3D tx_rs_thresh + tx_free_thresh. Suggested fix: Under all circumstances, rte_eth_dev_adjust_nb_rx_tx_desc() should take tx_rs_thresh and tx_free_thresh into consideration when adjusting nb_tx_desc for minimum allowed. Preferably, it should take an optional "const struct rte_eth_txconf *tx_con= f" parameter, like rte_eth_tx_queue_setup(), or it can use the tx_rs_thresh and tx_free_thresh values from default_txconf. --=20 You are receiving this mail because: You are the assignee for the bug.= --17264937150.A4ecabc7b.1362663 Date: Mon, 16 Sep 2024 15:35:15 +0200 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1544
Summary rte_eth_dev_adjust_nb_rx_tx_desc nb_tx_desc minimum incorrect
Product DPDK
Version 24.07
Hardware All
OS All
Status UNCONFIRMED
Severity normal
Priority Normal
Component ethdev
Assignee dev@dpdk.org
Reporter mb@smartsharesystems.com
Target Milestone --- 

rte_eth_dev_adjust_nb_rx_tx_desc()=
 does not consider tx_rs_thresh and
tx_free_thresh when adjusting nb_tx_desc for minimum allowed TX descriptors.

E.g. the IXGBE driver reports:
dev_info.tx_desc_lim.nb_min =3D 32.
dev_info.default_txconf.tx_rs_thresh =3D 32.
dev_info.default_txconf.tx_free_thresh =3D 32.

If calling rte_eth_dev_adjust_nb_rx_tx_desc() with nb_tx_desc =3D 32, it wi=
ll
adjust to nb_tx_desc =3D 32.

But then rte_eth_tx_queue_setup() will fail afterwards, because it needs
nb_tx_desc >=3D tx_rs_thresh + tx_free_thresh.

Suggested fix:
Under all circumstances, rte_eth_dev_adjust_nb_rx_tx_desc() should take
tx_rs_thresh and tx_free_thresh into consideration when adjusting nb_tx_desc
for minimum allowed.

Preferably, it should take an optional "const struct rte_eth_txconf *t=
x_conf"
parameter, like rte_eth_tx_queue_setup(), or it can use the tx_rs_thresh and
tx_free_thresh values from default_txconf.

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17264937150.A4ecabc7b.1362663--