From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E89345D5D; Wed, 20 Nov 2024 23:54:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16A3443249; Wed, 20 Nov 2024 23:54:12 +0100 (CET) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id 90E7A40DD0 for ; Wed, 20 Nov 2024 23:54:10 +0100 (CET) Received: by inbox.dpdk.org (Postfix, from userid 33) id 84E4145D5E; Wed, 20 Nov 2024 23:54:10 +0100 (CET) From: bugzilla@dpdk.org To: dev@dpdk.org Subject: [DPDK/ethdev Bug 1586] Drivers are doing useless check for pthread_mutex_init return value Date: Wed, 20 Nov 2024 22:54:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 24.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: stephen@networkplumber.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: multipart/alternative; boundary=17321432500.59AD4.809973 Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --17321432500.59AD4.809973 Date: Wed, 20 Nov 2024 23:54:10 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All https://bugs.dpdk.org/show_bug.cgi?id=3D1586 Bug ID: 1586 Summary: Drivers are doing useless check for pthread_mutex_init return value Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: stephen@networkplumber.org Target Milestone: --- Various checkers will warn that checking the return value of pthread_mutex_init() will always be zero. The documentation states: RETURN VALUE pthread_mutex_init always returns 0. The other mutex functions retu= rn 0 on success and a non-zero error code on error. Very minor issue, since it only results in bogus warnings and few instructi= ons of extra code in the startup path. drivers/common/cnxk/roc_bphy_cgx.c: ret =3D pthread_mutex_init(&roc_cgx->lock, NULL); drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->flow_lock, = NULL); drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->def_cp_lock, NULL); drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->health_check_lock, NULL); drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->err_recovery_lock, NULL); drivers/net/bnxt/bnxt_ethdev.c: rc =3D pthread_mutex_init(&bp->rep_info->vfr_start_lock, NULL); drivers/net/bnxt/bnxt_txq.c: rc =3D pthread_mutex_init(&txq->txq_lock, N= ULL); drivers/net/bnxt/tf_ulp/bnxt_ulp.c: rc =3D pthread_mutex_init(&session->bnxt_ulp_mutex, NULL); drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c: rc =3D pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL); drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c: rc =3D pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL); drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c: rc =3D pthread_mutex_init(&ulp_fc_info->fc_lock, NULL); drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c: rc =3D pthread_mutex_init(&ha_info->ha_lock, NULL); drivers/net/failsafe/failsafe.c: ret =3D pthread_mutex_init(&priv->hotplug_mutex, &attr); drivers/net/hinic/base/hinic_compat.h: err =3D pthread_mutex_init(pthreadm= utex, mattr); drivers/raw/ifpga/base/opae_intel_max10.c: ret =3D pthread_mutex_init(&dev->bmc_ops.lock, NULL); drivers/raw/ifpga/base/opae_spi_transaction.c: ret =3D pthread_mutex_init(&spi_tran_dev->lock, NULL); lib/vhost/socket.c: ret =3D pthread_mutex_init(&reconn_list.mutex, NULL= ); lib/vhost/socket.c: ret =3D pthread_mutex_init(&vsocket->conn_mutex, NU= LL); --=20 You are receiving this mail because: You are the assignee for the bug.= --17321432500.59AD4.809973 Date: Wed, 20 Nov 2024 23:54:10 +0100 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All
Bug ID 1586
Summary Drivers are doing useless check for pthread_mutex_init return= value
Product DPDK
Version 24.11
Hardware All
OS All
Status UNCONFIRMED
Severity minor
Priority Normal
Component ethdev
Assignee dev@dpdk.org
Reporter stephen@networkplumber.org
Target Milestone --- 

Various checkers will warn that ch=
ecking the return value of
pthread_mutex_init() will always be zero.

The documentation states:

RETURN VALUE
       pthread_mutex_init always returns 0.  The other mutex functions retu=
rn 0
       on success and a non-zero error code on error.

Very minor issue, since it only results in bogus warnings and few instructi=
ons
of extra code in the startup path.

drivers/common/cnxk/roc_bphy_cgx.c:     ret =3D
pthread_mutex_init(&roc_cgx->lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->flow=
_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c: err =3D pthread_mutex_init(&bp->def_=
cp_lock,
NULL);
drivers/net/bnxt/bnxt_ethdev.c: err =3D
pthread_mutex_init(&bp->health_check_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c: err =3D
pthread_mutex_init(&bp->err_recovery_lock, NULL);
drivers/net/bnxt/bnxt_ethdev.c: rc =3D
pthread_mutex_init(&bp->rep_info->vfr_start_lock, NULL);
drivers/net/bnxt/bnxt_txq.c:    rc =3D pthread_mutex_init(&txq->txq_=
lock, NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp.c:                     rc =3D
pthread_mutex_init(&session->bnxt_ulp_mutex, NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c:  rc =3D
pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL);
drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c: rc =3D
pthread_mutex_init(&bp->ulp_ctx->cfg_data->flow_db_lock, NULL);
drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c:   rc =3D
pthread_mutex_init(&ulp_fc_info->fc_lock, NULL);
drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c:   rc =3D
pthread_mutex_init(&ha_info->ha_lock, NULL);
drivers/net/failsafe/failsafe.c:        ret =3D
pthread_mutex_init(&priv->hotplug_mutex, &attr);
drivers/net/hinic/base/hinic_compat.h:  err =3D pthread_mutex_init(pthreadm=
utex,
mattr);
drivers/raw/ifpga/base/opae_intel_max10.c:              ret =3D
pthread_mutex_init(&dev->bmc_ops.lock, NULL);
drivers/raw/ifpga/base/opae_spi_transaction.c:  ret =3D
pthread_mutex_init(&spi_tran_dev->lock, NULL);
lib/vhost/socket.c:     ret =3D pthread_mutex_init(&reconn_list.mutex, =
NULL);
lib/vhost/socket.c:     ret =3D pthread_mutex_init(&vsocket->conn_mu=
tex, NULL);

You are receiving this mail because:
  • You are the assignee for the bug.
=20=20=20=20=20=20=20=20=20=20
= --17321432500.59AD4.809973--