DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1611] net/af_xdp, numa_node and socket_id is assigned incorrectly for numa scenario
Date: Tue, 07 Jan 2025 06:09:46 +0000	[thread overview]
Message-ID: <bug-1611-3@http.bugs.dpdk.org/> (raw)

[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1611

            Bug ID: 1611
           Summary: net/af_xdp, numa_node and socket_id is assigned
                    incorrectly for numa scenario
           Product: DPDK
           Version: 22.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: xiaohua.wang@ericsson.com
  Target Milestone: ---

1. in rte_pmd_af_xdp_probe() function, can't assign device.numa_node with
current socket id. Since the CPU core socket to start app can be different to
virtual xdp/device socket to attach. 
===========code in rte_eth_af_xdp.c===========================
        if (dev->device.numa_node == SOCKET_ID_ANY)
                dev->device.numa_node = rte_socket_id();
===========code in rte_eth_af_xdp.c===========================

Same issue for rte_pmd_af_xdp_remove() and eth_dev_close().

2. For xdp_umem_configure() in xsk_configure(), also can't allocate umem at CPU
core socket which get from during eth_rx_queue_setup() phase. Because it will
probably be different to socket which "umem" wants to attach port device
belongs to.
===========code in rte_eth_af_xdp.c===========================
        umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id());
        if (umem == NULL) {
                AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
                return NULL;
        }

        snprintf(ring_name, sizeof(ring_name), "af_xdp_ring_%s_%u",
                       internals->if_name, rxq->xsk_queue_idx);
        umem->buf_ring = rte_ring_create(ring_name,
                                         ETH_AF_XDP_NUM_BUFFERS,
                                         rte_socket_id(),
                                         0x0);
===========code in rte_eth_af_xdp.c===========================

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3988 bytes --]

                 reply	other threads:[~2025-01-07  6:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1611-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).