DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 179] mp_socket is not well handled when secondary process is exited
Date: Fri, 04 Jan 2019 11:02:26 +0000	[thread overview]
Message-ID: <bug-179-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=179

            Bug ID: 179
           Summary: mp_socket is not well handled when secondary process
                    is exited
           Product: DPDK
           Version: 18.11
          Hardware: x86
                OS: Linux
            Status: CONFIRMED
          Severity: critical
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: danielbenliye@gmail.com
  Target Milestone: ---

I am running dpdk-pdump and found the mp socket (see below output) it created
is not deleted when dpdk-pdump is exited. Now it can work because when
dpdk-dump call rte_eal_init(), rte_bus_scan() will be called and the file will
be removed. The path rte_bus_scan() -> bus->scan() -> vdev_scan() ->
rte_mp_request_sync() -> mp_request_sync() -> send_msg() -> sendmsg() will
eventually delete the mp_socket_* which is retained by last run.

--------
root@n14-045-219:~# ls /var/run/dpdk/rte/mp_socket_*
/var/run/dpdk/rte/mp_socket_21695_4467ff77b19ec2
--------

I do think this is not expected. When a secondary process is exited, the mp
socket file should be cleared in some way.

You can have the following way to reproduce it.
1. You need to change dpdk-pdump to call rte_eal_hotplug_remove("vdev",
vdev_name) when dpdk-pdump is exited. Otherwise dpdk-pdump can only run once as
vdev is not freed.
2. Run dpdk-pdump twice with testpmd, you will see the second run will fail
because of it send request to the mp_socket which is retained by last run.
    testpmd command:  testpmd -l 0-1 -n 4 --master-lcore 0 -- -a
    pdump comman: dpdk-pdump -- --pdump 'port=0,queue=*,rx-dev=/tmp/rx.pcap'

Please take a look at this and fix it.

Thanks,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2019-01-04 11:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-179-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).