DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1809] net/intel: possible misuse of comma operator
Date: Thu, 23 Oct 2025 23:45:31 +0000	[thread overview]
Message-ID: <bug-1809-3@http.bugs.dpdk.org/> (raw)

http://bugs.dpdk.org/show_bug.cgi?id=1809

            Bug ID: 1809
           Summary: net/intel: possible misuse of comma operator
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

If DPDK is built with clang and -Wcomma is enabled for drivers then:

[1127/3622] Compiling C object
drivers/libtmp_rte_net_ice.a.p/net_intel_ice_ice_ethdev.c.o
../drivers/net/intel/ice/ice_ethdev.c:945:52: warning: possible misuse of comma
operator here [-Wcomma]
  945 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                                                           ^
../drivers/net/intel/ice/ice_ethdev.c:945:17: note: cast expression to void to
silence warning
  945 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                        (void)(                            )
../drivers/net/intel/ice/ice_ethdev.c:952:52: warning: possible misuse of comma
operator here [-Wcomma]
  952 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                                                           ^
../drivers/net/intel/ice/ice_ethdev.c:952:17: note: cast expression to void to
silence warning
  952 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                        (void)(                            )
2 warnings generated.
[1150/3622] Compiling C object
drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_ethdev.c.o
../drivers/net/intel/i40e/i40e_ethdev.c:5102:49: warning: possible misuse of
comma operator here [-Wcomma]
 5102 |                         entry && (next_entry = LIST_NEXT(entry, next),
1);
      |                                                                      ^
../drivers/net/intel/i40e/i40e_ethdev.c:5102:14: note: cast expression to void
to silence warning
 5102 |                         entry && (next_entry = LIST_NEXT(entry, next),
1);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   (void)(                            )
../drivers/net/intel/i40e/i40e_ethdev.c:5109:49: warning: possible misuse of
comma operator here [-Wcomma]
 5109 |                         entry && (next_entry = LIST_NEXT(entry, next),
1);
      |                                                                      ^
../drivers/net/intel/i40e/i40e_ethdev.c:5109:14: note: cast expression to void
to silence warning
 5109 |                         entry && (next_entry = LIST_NEXT(entry, next),
1);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   (void)(                            )
2 warnings generated.


Suggest looking at how LIST_NEXT could be changed to not generate warnings, not
seen elsewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2025-10-23 23:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1809-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).