From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bugzilla@dpdk.org>
Received: by dpdk.org (Postfix, from userid 33)
 id 200925F14; Sun,  1 Apr 2018 14:30:07 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Sun, 01 Apr 2018 12:30:07 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: core
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: solal.pirelli@gmail.com
X-Bugzilla-Status: CONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-20-3@http.dpdk.org/tracker/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://dpdk.org/tracker/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 20] Undefined behavior caused by NUMA function in
	eal_memory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Apr 2018 12:30:07 -0000

https://dpdk.org/tracker/show_bug.cgi?id=3D20

            Bug ID: 20
           Summary: Undefined behavior caused by NUMA function in
                    eal_memory
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: Linux
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: solal.pirelli@gmail.com
  Target Milestone: ---

In linuxapp's eal_memory.c, the map_all_hugepages function begins by declar=
ing
and initializing variables, including a nodemask
(http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal_memory.c?=
h=3Dv18.02#n344).

However, this initialization occurs before the numa_available function is
called. According to the libnuma documentation
(https://linux.die.net/man/3/numa), all other functions have undefined beha=
vior
if numa_available returns -1.

The initialization of the nodemask needs to be moved after the numa_availab=
le
call, and consequently its freeing at the end of the function needs to be
conditional on it not being NULL.

--=20
You are receiving this mail because:
You are the assignee for the bug.=