DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 21] Ixgbe driver changes FCTRL without first disabling RXCTRL.RXEN
Date: Sun, 01 Apr 2018 12:37:39 +0000	[thread overview]
Message-ID: <bug-21-3@http.dpdk.org/tracker/> (raw)

https://dpdk.org/tracker/show_bug.cgi?id=21

            Bug ID: 21
           Summary: Ixgbe driver changes FCTRL without first disabling
                    RXCTRL.RXEN
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: solal.pirelli@gmail.com
  Target Milestone: ---

The Intel 82599 data sheet
(https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf,
§8.2.3.7.1) states that "Before receive filters are updated/modified the
RXCTRL.RXEN bit should be set to 0b. After the proper filters have been set the
RXCTRL.RXEN bit can be set to 1b to re-enable the receiver."

However, the ixgbe driver's promiscuous and allmulticast enable/disable
functions edit the FCTRL filters without disabling (or at least checking)
RXCTRL.RXEN. (e.g.
http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/ixgbe_ethdev.c?h=v18.02#n4053)

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2018-04-01 12:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-21-3@http.dpdk.org/tracker/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).