[dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error.

[dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error.

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=257

            Bug ID: 257
           Summary: ipc: rte_mp_request_sync return 0 on error.
           Product: DPDK
           Version: 18.11
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: herakliusz.lipiec@intel.com
  Target Milestone: ---

API can return success (0), but reply buffer might be invalid.

There are three code paths that can return a success, but have no (valid)
message.
In case of two I think it should be a failure.
In rte_mp_request_sync there is a call to mp_request_sync which may return 0
with no message in case of:
- failure to send the message on behalf of remote
- the caller not caring about reply message. (this is probably fine)
This is then returned as 0 by rte_mp_request_sync (docs say that it will return
0 on success).
If IPC is disabled rte_mp_request_sync also return 0, but i think it should be
a failure (it did not send anything, it did not received anything because
operation is not supported).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error.

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=257

            Bug ID: 257
           Summary: ipc: rte_mp_request_sync return 0 on error.
           Product: DPDK
           Version: 18.11
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: herakliusz.lipiec@intel.com
  Target Milestone: ---

API can return success (0), but reply buffer might be invalid.

There are three code paths that can return a success, but have no (valid)
message.
In case of two I think it should be a failure.
In rte_mp_request_sync there is a call to mp_request_sync which may return 0
with no message in case of:
- failure to send the message on behalf of remote
- the caller not caring about reply message. (this is probably fine)
This is then returned as 0 by rte_mp_request_sync (docs say that it will return
0 on success).
If IPC is disabled rte_mp_request_sync also return 0, but i think it should be
a failure (it did not send anything, it did not received anything because
operation is not supported).

-- 
You are receiving this mail because:
You are the assignee for the bug.