From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 33) id 0D44E1BC14; Fri, 19 Apr 2019 18:53:57 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Fri, 19 Apr 2019 16:53:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: 18.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: herakliusz.lipiec@intel.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 16:53:57 -0000 https://bugs.dpdk.org/show_bug.cgi?id=3D257 Bug ID: 257 Summary: ipc: rte_mp_request_sync return 0 on error. Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: herakliusz.lipiec@intel.com Target Milestone: --- API can return success (0), but reply buffer might be invalid. There are three code paths that can return a success, but have no (valid) message. In case of two I think it should be a failure. In rte_mp_request_sync there is a call to mp_request_sync which may return 0 with no message in case of: - failure to send the message on behalf of remote - the caller not caring about reply message. (this is probably fine) This is then returned as 0 by rte_mp_request_sync (docs say that it will re= turn 0 on success). If IPC is disabled rte_mp_request_sync also return 0, but i think it should= be a failure (it did not send anything, it did not received anything because operation is not supported). --=20 You are receiving this mail because: You are the assignee for the bug.= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2608AA00E6 for ; Fri, 19 Apr 2019 18:53:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC0551BC14; Fri, 19 Apr 2019 18:53:58 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 33) id 0D44E1BC14; Fri, 19 Apr 2019 18:53:57 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Fri, 19 Apr 2019 16:53:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: core X-Bugzilla-Version: 18.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: herakliusz.lipiec@intel.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419165356.XnbReSKXw7bZIENwr4S2LO5oyOVxp2XtPbhGkXK03i0@z> https://bugs.dpdk.org/show_bug.cgi?id=3D257 Bug ID: 257 Summary: ipc: rte_mp_request_sync return 0 on error. Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Normal Component: core Assignee: dev@dpdk.org Reporter: herakliusz.lipiec@intel.com Target Milestone: --- API can return success (0), but reply buffer might be invalid. There are three code paths that can return a success, but have no (valid) message. In case of two I think it should be a failure. In rte_mp_request_sync there is a call to mp_request_sync which may return 0 with no message in case of: - failure to send the message on behalf of remote - the caller not caring about reply message. (this is probably fine) This is then returned as 0 by rte_mp_request_sync (docs say that it will re= turn 0 on success). If IPC is disabled rte_mp_request_sync also return 0, but i think it should= be a failure (it did not send anything, it did not received anything because operation is not supported). --=20 You are receiving this mail because: You are the assignee for the bug.=