From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bugzilla@dpdk.org>
Received: by dpdk.org (Postfix, from userid 33)
 id 5E0232BF2; Sun,  1 Apr 2018 15:43:13 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Sun, 01 Apr 2018 13:43:13 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: solal.pirelli@gmail.com
X-Bugzilla-Status: CONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-26-3@http.dpdk.org/tracker/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://dpdk.org/tracker/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 26] Ixgbe driver does not ensure FWSM firmware mode
 is valid before using it
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Apr 2018 13:43:13 -0000

https://dpdk.org/tracker/show_bug.cgi?id=3D26

            Bug ID: 26
           Summary: Ixgbe driver does not ensure FWSM firmware mode is
                    valid before using it
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: solal.pirelli@gmail.com
  Target Milestone: ---

The Intel 82599 data sheet
(https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82=
599-10-gbe-controller-datasheet.pdf,
=C2=A78.2.3.4.10) states of the FWSM register's bit 15 (FW_Val_bit) that "H=
ardware
clears this bit in reset de-assertion so software can know firmware mode (b=
its
1-5) is invalid".

However, the ixgbe driver does not check that bit before using the firmware
mode, e.g. in ixgbe_mng_present
(http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/base/ixgbe_common.c?h=
=3Dv18.02#n5194).

--=20
You are receiving this mail because:
You are the assignee for the bug.=