DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 28] event/octeontx: snprintf() overflow
Date: Mon, 23 Apr 2018 10:35:49 +0000	[thread overview]
Message-ID: <bug-28-3@http.dpdk.org/tracker/> (raw)

https://dpdk.org/tracker/show_bug.cgi?id=28

            Bug ID: 28
           Summary: event/octeontx: snprintf() overflow
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: eventdev
          Assignee: dev@dpdk.org
          Reporter: harry.van.haaren@intel.com
                CC: pbhagavatula@caviumnetworks.com
  Target Milestone: ---

Compiling latest git with Meson and GCC 5.4, it prints a warning for always
overflowing a destination buffer.

[1/15] Compiling C object
'drivers/tmp_rte_..._event@sta/event_octeontx_timvf_evdev.c.o'
In file included from /usr/include/stdio.h:936:0,
                 from ../lib/librte_eal/common/include/rte_log.h:21,
                 from ../lib/librte_eal/common/include/rte_debug.h:17,
                 from ../lib/librte_eal/common/include/generic/rte_cycles.h:16,
                 from
../lib/librte_eal/common/include/arch/x86/rte_cycles.h:13,
                 from ../drivers/event/octeontx/timvf_evdev.h:10,
                 from ../drivers/event/octeontx/timvf_evdev.c:6:
In function ‘snprintf’,
    inlined from ‘timvf_ring_create’ at
../drivers/event/octeontx/timvf_evdev.c:298:2:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: warning: call to
__builtin___snprintf_chk will always overflow destination buffer
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,


/* Declaration of pool_name */
char pool_name[25];
...
/* offending line, note the mismatch in size 25 and 30 */
snprintf(pool_name, 30, "timvf_chunk_pool%d", timr->tim_ring_id);

Commited in f874c1eb1519185feba05a0542413492e5f56ae9

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2018-04-23 10:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28-3@http.dpdk.org/tracker/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).