* [dpdk-dev] [Bug 356] Building dpdk with rte_vhost sometimes fails due to missing rte_hash.h
@ 2019-10-23 10:48 bugzilla
2019-11-21 2:02 ` bugzilla
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla @ 2019-10-23 10:48 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=356
Bug ID: 356
Summary: Building dpdk with rte_vhost sometimes fails due to
missing rte_hash.h
Product: DPDK
Version: 19.05
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: minor
Priority: Normal
Component: vhost/virtio
Assignee: dev@dpdk.org
Reporter: jan.kryl@mayadata.io
Target Milestone: ---
This is because rte_vhost does not name rte_hash as its dependency in
lib/Makefile. Depending on -j and how knows what else the build either succeeds
or fails and is nondeterministic.
> == Build lib/librte_vhost
> SYMLINK-FILE include/rte_vhost.h
> SYMLINK-FILE include/rte_vdpa.h
> SYMLINK-FILE include/rte_vhost_crypto.h
> CC fd_man.o
> CC iotlb.o
> CC socket.o
> CC vhost.o
> CC vhost_user.o
> CC virtio_net.o
> CC vdpa.o
> CC vhost_crypto.o
>
> /tmp/nix-build-libspdk.drv-0/source/dpdk/lib/librte_vhost/vhost_crypto.c:5:10:
> > fatal error: rte_hash.h: No such file or directory
> #include <rte_hash.h>
> ^~~~~~~~~~~~
> compilation terminated.
The fix is simple. DEPDIRS for librte_vhost in lib/Makefile needs to explicitly
mention librte_hash:
> DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> librte_net librte_hash
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread* [dpdk-dev] [Bug 356] Building dpdk with rte_vhost sometimes fails due to missing rte_hash.h
2019-10-23 10:48 [dpdk-dev] [Bug 356] Building dpdk with rte_vhost sometimes fails due to missing rte_hash.h bugzilla
@ 2019-11-21 2:02 ` bugzilla
0 siblings, 0 replies; 2+ messages in thread
From: bugzilla @ 2019-11-21 2:02 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=356
Maxime Coquelin (maxime.coquelin@redhat.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |maxime.coquelin@redhat.com
Resolution|--- |FIXED
--- Comment #1 from Maxime Coquelin (maxime.coquelin@redhat.com) ---
Patch fixing the issue merged in v19.11-rc3:
commit 201e7482674551aeee27d0ff28e7bbd3fbfbbcf2
Author: Jin Yu <jin.yu@intel.com>
Date: Wed Oct 30 17:40:55 2019 +0800
vhost: fix build dependency on hash lib
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: stable@dpdk.org
Signed-off-by: Jin Yu <jin.yu@intel.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-21 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 10:48 [dpdk-dev] [Bug 356] Building dpdk with rte_vhost sometimes fails due to missing rte_hash.h bugzilla
2019-11-21 2:02 ` bugzilla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).