From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C012DA0350;
	Fri, 22 May 2020 15:26:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A36721D995;
	Fri, 22 May 2020 15:26:17 +0200 (CEST)
Received: from inbox.dpdk.org (xvm-172-178.dc0.ghst.net [95.142.172.178])
 by dpdk.org (Postfix) with ESMTP id 7DCCC1D985
 for <dev@dpdk.org>; Fri, 22 May 2020 15:26:15 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 64F1EA04A2; Fri, 22 May 2020 15:26:15 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Fri, 22 May 2020 13:26:14 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: other
X-Bugzilla-Version: 19.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: major
X-Bugzilla-Who: hrvoje.habjanic@zg.ht.hr
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone attachments.created
Message-ID: <bug-484-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 484] rte_sched_subport_free function does not free
 subport memory
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D484

            Bug ID: 484
           Summary: rte_sched_subport_free function does not free subport
                    memory
           Product: DPDK
           Version: 19.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: hrvoje.habjanic@zg.ht.hr
  Target Milestone: ---

Created attachment 105
  --> https://bugs.dpdk.org/attachment.cgi?id=3D105&action=3Dedit
Patch to fix rte_sched_subport_free leak

Hi.

It would seem that rte_sched_subport_free does not properly free allocated
subport memory.

In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865),
there is code to free all allocated stuff related to scheduler subport. Fir=
st
there are some checks, and in the end, rte_bitmap_free is called.

Now, rte_bitmap_free is a dummy function, and it just checks if provided
pointer to bitmap is valid or not. So, actual memory for subport is not fre=
ed,
and this is shown as memory leak.

Fix is quite simple, rte_bitmap_free should be replaced with rte_free, and
argument should be changed to subport pointer.

Regards,

H.

--=20
You are receiving this mail because:
You are the assignee for the bug.=