From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id ED298A0528;
	Fri, 10 Jul 2020 11:10:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 414401DB9C;
	Fri, 10 Jul 2020 11:10:18 +0200 (CEST)
Received: from inbox.dpdk.org (xvm-172-178.dc0.ghst.net [95.142.172.178])
 by dpdk.org (Postfix) with ESMTP id 103C91DB49
 for <dev@dpdk.org>; Fri, 10 Jul 2020 11:10:16 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id D8D48A0529; Fri, 10 Jul 2020 11:10:15 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Fri, 10 Jul 2020 09:10:16 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 20.05
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: frederic.coiffier@6cure.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-506-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 506] i40e: Fix for rte_eth_dev_get_module_eeprom()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D506

            Bug ID: 506
           Summary: i40e: Fix for rte_eth_dev_get_module_eeprom()
           Product: DPDK
           Version: 20.05
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: frederic.coiffier@6cure.com
  Target Milestone: ---

In DPDK 20.05 (and maybe previous versions), the
rte_eth_dev_get_module_eeprom() returns 512 bytes but all bytes are equal to
0x04.

Therefore, using the official Intel i40e 2.11.29 with ethtool -m works fine.

By comparing the 2 source code, we found a small typo in
i40e_get_module_eeprom():

- i40e-2.11.29:

                status =3D i40e_aq_get_phy_register(hw,
                                I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
                                addr, true, offset, &value, NULL);

- DPDK 20.05:

                status =3D i40e_aq_get_phy_register(hw,
                                I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
                                addr, offset, 1, &value, NULL);

By swapping offset and 1 in the DPDK source code, the
rte_eth_dev_get_module_eeprom() function works fine.

--=20
You are receiving this mail because:
You are the assignee for the bug.=