From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 53E3FA04B0;
	Fri,  7 Aug 2020 17:36:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id AADD22BF2;
	Fri,  7 Aug 2020 17:36:44 +0200 (CEST)
Received: from inbox.dpdk.org (xvm-172-178.dc0.ghst.net [95.142.172.178])
 by dpdk.org (Postfix) with ESMTP id D5A3A2BF1
 for <dev@dpdk.org>; Fri,  7 Aug 2020 17:36:42 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 9A254A04B1; Fri,  7 Aug 2020 17:36:42 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Fri, 07 Aug 2020 15:36:42 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 18.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iryzhov@nfware.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-521-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 521] i40e: incorrect byte counters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D521

            Bug ID: 521
           Summary: i40e: incorrect byte counters
           Product: DPDK
           Version: 18.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: iryzhov@nfware.com
  Target Milestone: ---

After running under 10G traffic over 3 days, the X710 card starts showing
incorrect RX/TX bytes statistics.

The problem seems to happen because of the following code in
i40e_update_vsi_stats:

        /* exclude CRC bytes */
        nes->rx_bytes -=3D (nes->rx_unicast + nes->rx_multicast +
                nes->rx_broadcast) * ETHER_CRC_LEN;

The rx_bytes counter in X710 cards is 48-bit long, so it takes around 3 day=
s to
overflow. When it overflows, it becomes less than (rx_pkts * ETHER_CRC_LEN),
and the substruction makes it a negative number, or, to be more precise, a =
very
big positive number, as it's uint64_t.

For XL710 40G cards, it will take less than one day to face the issue.

--=20
You are receiving this mail because:
You are the assignee for the bug.=