From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2A2C4A04BC;
	Fri,  9 Oct 2020 20:23:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 087E41C236;
	Fri,  9 Oct 2020 20:23:06 +0200 (CEST)
Received: from inbox.dpdk.org (xvm-172-178.dc0.ghst.net [95.142.172.178])
 by dpdk.org (Postfix) with ESMTP id 8AC831C1E5
 for <dev@dpdk.org>; Fri,  9 Oct 2020 20:23:03 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 7ACCAA04C0; Fri,  9 Oct 2020 20:23:03 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Fri, 09 Oct 2020 18:23:03 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: eventdev
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: kiran.kn80@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-549-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 549] With offloads,
 bond device initialization fails with command-line bond arguments
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D549

            Bug ID: 549
           Summary: With offloads, bond device initialization fails with
                    command-line bond arguments
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: eventdev
          Assignee: dev@dpdk.org
          Reporter: kiran.kn80@gmail.com
  Target Milestone: ---

In Tungsten fabric, we are trying to initialize bond device using the
command-line vdev argument -=20

"--vdev
eth_bond_bond0,mode=3D4,xmit_policy=3Dl34,socket_id=3D0,mac=3D00:1b:21:bb:f=
9:48,lacp_rate=3D0,slave=3D0000:02:00.0,slave=3D0000:02:00.1"

We have the bond device offloads set - DEV_RX_OFFLOAD_CHECKSUM and
DEV_RX_OFFLOAD_JUMBO_FRAME

It fails here -
https://github.com/DPDK/dpdk/blob/main/lib/librte_ethdev/rte_ethdev.c#L1378

In DPDK 18.05, this "return" was not present, but it's added in DPDK 19.11.

The reason it fails there is because bond inherits offloads from slave. But=
 in
case where command-line arguments are present for the bond, the slave is
initialized from the bond driver later and so it is not initialized. Due to
this, offloads are not inherited to the bond device and the above check fai=
ls.

I have discussed this with Doherty, Declan <declan.doherty@intel.com> and he
agrees this needs to be fixed.

--=20
You are receiving this mail because:
You are the assignee for the bug.=