[dpdk-dev] [Bug 582] [Regression Test] usertools/dpdk-devbind.py: execute "./usertools/dpdk-devbind.py --status-dev misc" command to get CBDMA device info failed.

[dpdk-dev] [Bug 582] [Regression Test] usertools/dpdk-devbind.py: execute "./usertools/dpdk-devbind.py --status-dev misc" command to get CBDMA device info failed.

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=582

            Bug ID: 582
           Summary: [Regression Test] usertools/dpdk-devbind.py: execute
                    "./usertools/dpdk-devbind.py --status-dev misc"
                    command to get CBDMA device info failed.
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: weix.ling@intel.com
  Target Milestone: ---

DPDK version: 
61bd270c4adc7dff1f9c8af1f2c72618860d4395 refs/heads/main
Other software versions: name/version for QEMU, OVS, etc. Repeat as required.
OS: 5.3.0-59-generic/Ubuntu 18.04.5 LTS
Compiler: gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)
Hardware platform: Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz.
NIC hardware: Ethernet Controller XL710 for 40GbE QSFP+ 1583.
NIC firmware: i40e_2.13.10/8.00 0x80008b8a 1.2766.0
Test Setup
Steps to reproduce
List the steps to reproduce the issue.

# tar -xvf dpdk.tar.gz
# cd dpdk
# ./usertools/dpdk-devbind.py --status-dev misc
Show the output from the previous commands.

# root@dpdk-Perf-dut222:/home/autoregression/dts/dts/dep/dpdk#
./usertools/dpdk-devbind.py --status-dev misc
usage: dpdk-devbind.py [-h] [-s]
                       [--status-dev
{net,baseband,crypto,event,mempool,compress}]
                       [-b DRIVER | -u] [--force]
                       [DEVICE [DEVICE ...]]
dpdk-devbind.py: error: argument --status-dev: invalid choice: 'misc' (choose
from 'net', 'baseband', 'crypto', 'event', 'mempool', 'compress')

Expected Result
Explain what is the expected result in text or as an example output:

# root@dpdk-Perf-dut222:~# dpdk-devbind.py --status-dev miscMisc (rawdev)
devices using kernel driver
=========================================
0000:00:04.0 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.1 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.2 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.3 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.4 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.5 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.6 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:00:04.7 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.0 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.1 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.2 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.3 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.4 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.5 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.6 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
0000:80:04.7 'Sky Lake-E CBDMA Registers 2021' if= drv=ioatdma
unused=igb_uio,vfio-pci
Regression
Is this issue a regression: (Y)

Version the regression was introduced: Specify git id if known.

Bad commit:

commit 81255f27c65c7f42f50ee8dfb0feeb40c36c4c61 (HEAD)
Author: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue Nov 3 22:48:41 2020 -0800

usertools: replace optparse with argparse

The optparse module is deprecated and replaced with new argparse.
Using the python standard argument parser instead of C library
style getopt gives a number of advantages such as checking
for conflicting arguments, restricting choices, and automatically
generating help messages.

Some of the help messages are now less wordy.

The code now enforces the rule that only one of the pmdinfo formats
can be specified: raw or json.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device classes

[Bruce Richardson]

The "misc" and "regex" device classes were missing from the list used to
check arguments, preventing them from being used with "--status-dev"
flag to list only devices of those types.

When adding them to the list, the list is also sorted alphabetically for
consistency.

Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
Cc: stephen@networkplumber.org

Bugzilla ID: 582

Reported-by: Wei Ling <weix.ling@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 usertools/dpdk-devbind.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 054ad2e1c..c2ede3d4d 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -634,7 +634,8 @@ def parse_args():
     parser.add_argument(
         '--status-dev',
         help="Print the status of given device group.",
-        choices=['net', 'baseband', 'crypto', 'event', 'mempool', 'compress'])
+        choices=['baseband', 'compress', 'crypto', 'event',
+                'mempool', 'misc', 'net', 'regex'])
     bind_group = parser.add_mutually_exclusive_group()
     bind_group.add_argument(
         '-b',
-- 
2.27.0

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device classes

[Stephen Hemminger]

On Tue, 24 Nov 2020 09:46:56 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:

> The "misc" and "regex" device classes were missing from the list used to
> check arguments, preventing them from being used with "--status-dev"
> flag to list only devices of those types.
> 
> When adding them to the list, the list is also sorted alphabetically for
> consistency.
> 
> Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> Cc: stephen@networkplumber.org
> 
> Bugzilla ID: 582
> 
> Reported-by: Wei Ling <weix.ling@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Almost the same patch I was sending right now...

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device classes

[Jiang, YuX]

Tested-by: Jiang, YuX <yux.jiang@intel.com>

    Best Regards
    Jiang yu

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, November 25, 2020 1:53 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device
> classes
> 
> On Tue, 24 Nov 2020 09:46:56 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> > The "misc" and "regex" device classes were missing from the list used
> > to check arguments, preventing them from being used with "--status-dev"
> > flag to list only devices of those types.
> >
> > When adding them to the list, the list is also sorted alphabetically
> > for consistency.
> >
> > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > Cc: stephen@networkplumber.org
> >
> > Bugzilla ID: 582
> >
> > Reported-by: Wei Ling <weix.ling@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Almost the same patch I was sending right now...
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device classes

[Thomas Monjalon]

25/11/2020 03:23, Jiang, YuX:
> Tested-by: Jiang, YuX <yux.jiang@intel.com>

Thanks for the test.
Next time, please reply below with this exact line (name):

Tested-by: Yu Jiang <yux.jiang@intel.com>


> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> > Hemminger
> > Sent: Wednesday, November 25, 2020 1:53 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device
> > classes
> > 
> > On Tue, 24 Nov 2020 09:46:56 +0000
> > Bruce Richardson <bruce.richardson@intel.com> wrote:
> > 
> > > The "misc" and "regex" device classes were missing from the list used
> > > to check arguments, preventing them from being used with "--status-dev"
> > > flag to list only devices of those types.
> > >
> > > When adding them to the list, the list is also sorted alphabetically
> > > for consistency.
> > >
> > > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > > Cc: stephen@networkplumber.org
> > >
> > > Bugzilla ID: 582
> > >
> > > Reported-by: Wei Ling <weix.ling@intel.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Almost the same patch I was sending right now...
> > 
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device classes

[Thomas Monjalon]

24/11/2020 18:53, Stephen Hemminger:
> On Tue, 24 Nov 2020 09:46:56 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> > The "misc" and "regex" device classes were missing from the list used to
> > check arguments, preventing them from being used with "--status-dev"
> > flag to list only devices of those types.
> > 
> > When adding them to the list, the list is also sorted alphabetically for
> > consistency.
> > 
> > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > Cc: stephen@networkplumber.org
> > 
> > Bugzilla ID: 582
> > 
> > Reported-by: Wei Ling <weix.ling@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Almost the same patch I was sending right now...
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks

[dpdk-dev] [Bug 582] [dpdk-20.11] usertools/dpdk-devbind.py "misc" option no longer available

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=582

jiang,yu (yux.jiang@intel.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from jiang,yu (yux.jiang@intel.com) ---
Verified patchset http://patches.dpdk.org/patch/84498/ on baseline 61bd270c4
version: 20.11-rc5.
Tested pass on fvl40G / Ubuntu 18.04.5 LTS
https://mails.dpdk.org/archives/dev/2020-November/193443.html

-- 
You are receiving this mail because:
You are the assignee for the bug.