From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0B86A0A02;
	Wed, 24 Mar 2021 09:45:16 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7DA3F4067B;
	Wed, 24 Mar 2021 09:45:16 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id 603164014F
 for <dev@dpdk.org>; Wed, 24 Mar 2021 09:45:15 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 3D3E1A0A0A; Wed, 24 Mar 2021 09:45:15 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 24 Mar 2021 08:45:14 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: minor
X-Bugzilla-Who: barbette@kth.se
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-664-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 664] ixgbe: Calling rte_eth_dev_rss_reta_update
 before rte_eth_dev_start sets device in wrong state
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D664

            Bug ID: 664
           Summary: ixgbe: Calling rte_eth_dev_rss_reta_update before
                    rte_eth_dev_start sets device in wrong state
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: barbette@kth.se
  Target Milestone: ---

If one calls rte_eth_dev_rss_reta_update with ixgbe before starting the dev=
ice
(but after setting everything else), then the table will be full of zeroes
after starting the device.

I would expect one of the following behavior:

 - Either the documentation should say RETA should be set after the device
starts, and the RSS configuration should therefore be ignored and
rte_eth_dev_rss_reta_update return an error
- Ot can be done and the configuration is kept.

In this case, it's half between as if it's called without errors, then the =
RSS
table will be full zeroes (instead of my table content or the default
sequential list).

Of course I prefer the second option. And some devices like Mellanox ones
actually need to set the reta table before the device starts, else it will
cause a device restart... But I understand ixgbe is old so maybe returning =
an
error in rte_eth_dev_rss_reta_update  if the device is not started yet is an
acceptable fix.

--=20
You are receiving this mail because:
You are the assignee for the bug.=