From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C476DA0A02;
	Wed, 24 Mar 2021 23:59:40 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A58FF40693;
	Wed, 24 Mar 2021 23:59:40 +0100 (CET)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id AC25640683
 for <dev@dpdk.org>; Wed, 24 Mar 2021 23:59:39 +0100 (CET)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id 8E57BA0A0A; Wed, 24 Mar 2021 23:59:39 +0100 (CET)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 24 Mar 2021 22:59:39 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 20.05
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sbaranoff@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-665-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 665] i40e MBUF_FAST_FREE wrong check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D665

            Bug ID: 665
           Summary: i40e MBUF_FAST_FREE wrong check
           Product: DPDK
           Version: 20.05
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: sbaranoff@gmail.com
  Target Milestone: ---

In i40e_rxtx.c in i40e_set_tx_function_flag there's an assignment to
ad->tx_simple_allowed that includes a check for enabling "tx_simple_allowed=
":

txq->offloads =3D=3D (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE)

This appears to be wrong to me. If no offload flags are set then 0 =3D=3D 0=
 &
<anything> is true. This means that if DEV_TX_OFFLOAD_MBUF_FAST_FREE is NOT=
 set
(and no other flags are set) then this check will still enable
`tx_simple_allowed`.


As best I can tell, this causes an issue with multiple mbuf pools are being
used to feed a single TX queue and no offload flags enable.

--=20
You are receiving this mail because:
You are the assignee for the bug.=