From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 906C2A034F;
	Mon, 29 Mar 2021 11:57:20 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 58EF240151;
	Mon, 29 Mar 2021 11:57:20 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id CE37240042
 for <dev@dpdk.org>; Mon, 29 Mar 2021 11:57:19 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id B0E88A0547; Mon, 29 Mar 2021 11:57:19 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Mon, 29 Mar 2021 09:57:19 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: other
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: major
X-Bugzilla-Who: michallinuxstuff@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-668-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 668] DPDK power governor fails if base_frequency is
 not opened
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D668

            Bug ID: 668
           Summary: DPDK power governor fails if base_frequency is not
                    opened
           Product: DPDK
           Version: 20.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: michallinuxstuff@gmail.com
  Target Milestone: ---

DPDK fails to initialize pstate cpufreq in case base_frequency is missing f=
rom
sysfs under given cpu. This is a bit problematic now since this particular =
attr
exists only under specific conditions: active intel_pstate + HWP supported =
by
the cpu. Also, from the commit itself (4db9587bbf) it looks like this was p=
ut
in place by accident since the part which accepts missing base_frequency (a=
nd
which sets it to 0) still exists, i.e.:


   snprintf(fullpath_base, sizeof(fullpath_base), POWER_SYSFILE_BASE_FREQ,
                        pi->lcore_id);

        f_base =3D fopen(fullpath_base, "r");=20
        FOPEN_OR_ERR_RET(f_base, -1); /* <- point of failure */
        if (f_base =3D=3D NULL) {
                /* No sysfs base_frequency, that's OK, continue without */
                base_ratio =3D 0;


Initially noticed under https://github.com/spdk/spdk/issues/1859.

Any feedback on the matter would be appreciate. :)

--=20
You are receiving this mail because:
You are the assignee for the bug.=