From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BE78CA0A0C;
	Wed,  4 Aug 2021 19:00:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7D06640E32;
	Wed,  4 Aug 2021 19:00:00 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id E154640143
 for <dev@dpdk.org>; Wed,  4 Aug 2021 18:59:58 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id C0B07A0C40; Wed,  4 Aug 2021 18:59:58 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 04 Aug 2021 16:59:58 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: netuio
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dg573847474@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-775-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 775] Potential error(e.g., resource leak,
 deadlock) due to the unreleased lock
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D775

            Bug ID: 775
           Summary: Potential error(e.g., resource leak, deadlock) due to
                    the unreleased lock
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: netuio
          Assignee: dev@dpdk.org
          Reporter: dg573847474@gmail.com
  Target Milestone: ---

source:
drivers/net/mlx5/mlx5_txpp.c

Hi, developers, thank you for your checking. The lock sh->txpp.mutex may no=
t be
correctly released if the !sh->txpp.refcnt || --sh->txpp.refcnt is true and
control flow goes to the branch listed below. Finally, the method returns w=
ith
the unreleased lock. The fix is to insert
pthread_mutex_unlock(&sh->txpp.mutex); before returning.

void
mlx5_txpp_stop(struct rte_eth_dev *dev)
{
        struct mlx5_priv *priv =3D dev->data->dev_private;
        struct mlx5_dev_ctx_shared *sh =3D priv->sh;
        int ret;

        if (!priv->txpp_en) {
                /* Packet pacing is already disabled for the device. */
                return;
        }
        priv->txpp_en =3D 0;
        ret =3D pthread_mutex_lock(&sh->txpp.mutex);
        MLX5_ASSERT(!ret);
        RTE_SET_USED(ret);
        MLX5_ASSERT(sh->txpp.refcnt);
        if (!sh->txpp.refcnt || --sh->txpp.refcnt)
                return; // the method returns with unreleased lock
        /* No references any more, do actual destroy. */
        mlx5_txpp_destroy(sh);
        ret =3D pthread_mutex_unlock(&sh->txpp.mutex);
        MLX5_ASSERT(!ret);
        RTE_SET_USED(ret);
}

--=20
You are receiving this mail because:
You are the assignee for the bug.=