From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 24E28A0A0C;
	Wed,  4 Aug 2021 19:03:29 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD18E41252;
	Wed,  4 Aug 2021 19:03:28 +0200 (CEST)
Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])
 by mails.dpdk.org (Postfix) with ESMTP id BB1F641250
 for <dev@dpdk.org>; Wed,  4 Aug 2021 19:03:27 +0200 (CEST)
Received: by inbox.dpdk.org (Postfix, from userid 33)
 id AB9E2A0C40; Wed,  4 Aug 2021 19:03:27 +0200 (CEST)
From: bugzilla@dpdk.org
To: dev@dpdk.org
Date: Wed, 04 Aug 2021 17:03:27 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: DPDK
X-Bugzilla-Component: ethdev
X-Bugzilla-Version: 20.11
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dg573847474@gmail.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: dev@dpdk.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 target_milestone
Message-ID: <bug-777-3@http.bugs.dpdk.org/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.dpdk.org/
Auto-Submitted: auto-generated
X-Auto-Response-Suppress: All
MIME-Version: 1.0
Subject: [dpdk-dev] [Bug 777] Potential error(e.g., resource leak,
 deadlock) due to the unreleased lock pdata->i2c_mutex
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D777

            Bug ID: 777
           Summary: Potential error(e.g., resource leak, deadlock) due to
                    the unreleased lock pdata->i2c_mutex
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: dg573847474@gmail.com
  Target Milestone: ---

source:
drivers/net/axgbe/axgbe_i2c.c

Hi, developers, thank you for your checking. The lock &pdata->i2c_mutex may=
 not
be correctly released if the ret=3D=3D1 and control flow goes to these two =
branches
listed below. Finally, the method returns with the unreleased lock. The fix=
 is
to insert pthread_mutex_unlock(&pdata->i2c_mutex); before returning.


static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op)
{
        ...;
        pthread_mutex_lock(&pdata->i2c_mutex);
        ret =3D axgbe_i2c_disable(pdata);
        if (ret) {
                PMD_DRV_LOG(ERR, "failed to disable i2c master\n");
                return ret; // the method returns with unreleased lock
        }

        ...;
        ret =3D axgbe_i2c_enable(pdata);
        if (ret) {
                PMD_DRV_LOG(ERR, "failed to enable i2c master\n");
                return ret; // the method returns with unreleased lock
        }

        ...;
}

--=20
You are receiving this mail because:
You are the assignee for the bug.=