* [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory
@ 2021-09-23 20:29 bugzilla
2021-09-23 20:37 ` spyroot
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla @ 2021-09-23 20:29 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=814
Bug ID: 814
Summary: Intel PMD both i40 and iavf send
OP_DISABLE_VLAN_STRIPPING and it not mandatory
Product: DPDK
Version: 20.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: dev@dpdk.org
Reporter: spyroot@gmail.com
Target Milestone: ---
Hi Folks,
There is an issue in i40 and ivfx PMD's both drivers send optional commands
that require trusted mode enabled and if OP_DISABLE_VLAN_STRIPPING discard by
PF, PMD return error and not gracefully handles.
Example iavf_disable_vlan_strip() same function present in i40 that disable
vlan strip. That is optional and not required and must be gracefully be
handled.
EAL: Detected 4 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: No available hugepages reported in hugepages-1048576kB
EAL: Probing VFIO support...
EAL: Probe PCI driver: net_iavf (8086:1889) device: 0000:13:00.0 (socket 0)
EAL: Error reading from file descriptor 26: Input/output error
EAL: No legacy callbacks, legacy socket not created
testpmd: create a new mbuf pool <mb_pool_0>: n=171456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
Warning! port-topology=paired and odd forward ports number, the last port will
pair with itself.
Configuring Port 0 (socket 0)
iavf_execute_vf_cmd(): No response for cmd 28
iavf_disable_vlan_strip(): Failed to execute command of
OP_DISABLE_VLAN_STRIPPING
iavf_init_rss(): RSS is enabled by PF by default
iavf_execute_vf_cmd(): No response for cmd 24
iavf_configure_rss_lut(): Failed to execute command of OP_CONFIG_RSS_LUT
iavf_dev_configure(): configure rss failed
Port0 dev_configure = -1
Fail to configure port 0
EAL: Error - exiting with code: 1
Cause: Start ports failed
Thank you,
Mus>
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory
2021-09-23 20:29 [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory bugzilla
@ 2021-09-23 20:37 ` spyroot
0 siblings, 0 replies; 2+ messages in thread
From: spyroot @ 2021-09-23 20:37 UTC (permalink / raw)
To: bugzilla; +Cc: dev
The second issue is in CONFIG_RSS_LUT.
That *VIRTCHNL_OP_CONFIG_RSS_LUT*
<http://code.dpdk.org/dpdk/v20.05/ident/VIRTCHNL_OP_CONFIG_RSS_LUT>; is
optional so if it returns ret it must be handled correctly.
int
*iavf_configure_rss_lut*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_configure_rss_lut>(struct
*iavf_adapter* <http://code.dpdk.org/dpdk/v20.05/ident/iavf_adapter>
*adapter)
{
struct *iavf_info*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_info> *vf =
*IAVF_DEV_PRIVATE_TO_VF*
<http://code.dpdk.org/dpdk/v20.05/ident/IAVF_DEV_PRIVATE_TO_VF>(adapter);
struct *virtchnl_rss_lut*
<http://code.dpdk.org/dpdk/v20.05/ident/virtchnl_rss_lut> *rss_lut;
struct *iavf_cmd_info*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_cmd_info> args;
int len, err = 0;
len = sizeof(*rss_lut) + vf->vf_res->rss_lut_size - 1;
rss_lut = *rte_zmalloc*
<http://code.dpdk.org/dpdk/v20.05/ident/rte_zmalloc>("rss_lut", len,
0);
if (!rss_lut)
return -ENOMEM;
rss_lut->vsi_id = vf->vsi_res->vsi_id;
rss_lut->lut_entries = vf->vf_res->rss_lut_size;
*rte_memcpy*
<http://code.dpdk.org/dpdk/v20.05/ident/rte_memcpy>(rss_lut->lut,
vf->rss_lut, vf->vf_res->rss_lut_size);
args.ops = *VIRTCHNL_OP_CONFIG_RSS_LUT*
<http://code.dpdk.org/dpdk/v20.05/ident/VIRTCHNL_OP_CONFIG_RSS_LUT>;
args.in_args = (*u8*
<http://code.dpdk.org/dpdk/v20.05/ident/u8> *)rss_lut;
args.in_args_size = len;
args.out_buffer = vf->aq_resp;
args.out_size = *IAVF_AQ_BUF_SZ*
<http://code.dpdk.org/dpdk/v20.05/ident/IAVF_AQ_BUF_SZ>;
err = *iavf_execute_vf_cmd*
<http://code.dpdk.org/dpdk/v20.05/ident/iavf_execute_vf_cmd>(adapter,
&args);
if (err)
*PMD_DRV_LOG*
<http://code.dpdk.org/dpdk/v20.05/ident/PMD_DRV_LOG>(ERR,
"Failed to execute command of OP_CONFIG_RSS_LUT");
*rte_free* <http://code.dpdk.org/dpdk/v20.05/ident/rte_free>(rss_lut);
return err;
}
On Fri, Sep 24, 2021 at 12:29 AM <bugzilla@dpdk.org> wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=814
>
> Bug ID: 814
> Summary: Intel PMD both i40 and iavf send
> OP_DISABLE_VLAN_STRIPPING and it not mandatory
> Product: DPDK
> Version: 20.11
> Hardware: All
> OS: All
> Status: UNCONFIRMED
> Severity: normal
> Priority: Normal
> Component: core
> Assignee: dev@dpdk.org
> Reporter: spyroot@gmail.com
> Target Milestone: ---
>
> Hi Folks,
>
> There is an issue in i40 and ivfx PMD's both drivers send optional commands
> that require trusted mode enabled and if OP_DISABLE_VLAN_STRIPPING discard
> by
> PF, PMD return error and not gracefully handles.
>
>
> Example iavf_disable_vlan_strip() same function present in i40 that disable
> vlan strip. That is optional and not required and must be gracefully be
> handled.
>
>
> EAL: Detected 4 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'PA'
> EAL: No available hugepages reported in hugepages-1048576kB
> EAL: Probing VFIO support...
> EAL: Probe PCI driver: net_iavf (8086:1889) device: 0000:13:00.0 (socket 0)
> EAL: Error reading from file descriptor 26: Input/output error
> EAL: No legacy callbacks, legacy socket not created
> testpmd: create a new mbuf pool <mb_pool_0>: n=171456, size=2176, socket=0
> testpmd: preferred mempool ops selected: ring_mp_mc
>
> Warning! port-topology=paired and odd forward ports number, the last port
> will
> pair with itself.
>
> Configuring Port 0 (socket 0)
> iavf_execute_vf_cmd(): No response for cmd 28
> iavf_disable_vlan_strip(): Failed to execute command of
> OP_DISABLE_VLAN_STRIPPING
> iavf_init_rss(): RSS is enabled by PF by default
> iavf_execute_vf_cmd(): No response for cmd 24
> iavf_configure_rss_lut(): Failed to execute command of OP_CONFIG_RSS_LUT
> iavf_dev_configure(): configure rss failed
> Port0 dev_configure = -1
> Fail to configure port 0
> EAL: Error - exiting with code: 1
> Cause: Start ports failed
>
> Thank you,
> Mus>
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-23 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 20:29 [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory bugzilla
2021-09-23 20:37 ` spyroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).