From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 838] [ubsan] bnxt: left shift cannot be represented in bnxt_hwrm_ver_get()
Date: Tue, 26 Oct 2021 09:47:40 +0000 [thread overview]
Message-ID: <bug-838-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=838
Bug ID: 838
Summary: [ubsan] bnxt: left shift cannot be represented in
bnxt_hwrm_ver_get()
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: burner-email@caramail.com
Target Milestone: ---
Hello,
An issue found by UBSan:
DPDK/drivers/net/bnxt/bnxt_hwrm.c:X:Y: runtime error: left shift of 216 by 24
places cannot be represented in type 'int'.
The offending code is in bnxt_hwrm_ver_get():
bp->fw_ver = (resp->hwrm_fw_maj_8b << 24) | <--- HERE
(resp->hwrm_fw_min_8b << 16) |
(resp->hwrm_fw_bld_8b << 8) |
resp->hwrm_fw_rsvd_8b;
The left shifts here are of type 'int', and the first one cannot be
represented. This is an undefined behavior.
The first shift should be explicitly cast to uint32_t, ie:
bp->fw_ver = ((uint32_t)resp->hwrm_fw_maj_8b << 24) |
(resp->hwrm_fw_min_8b << 16) |
(resp->hwrm_fw_bld_8b << 8) |
resp->hwrm_fw_rsvd_8b;
I have tested this patch, and could confirm with UBSan that there is no
undefined behavior anymore.
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2021-10-26 9:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-838-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).