DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 934] crypto_aesni_mb PMD found crash in access mb_mgr on primary process after secondary process launch scan/probe
Date: Mon, 07 Feb 2022 00:35:57 +0000	[thread overview]
Message-ID: <bug-934-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=934

            Bug ID: 934
           Summary: crypto_aesni_mb PMD found crash in access mb_mgr on
                    primary process after secondary process launch
                    scan/probe
           Product: DPDK
           Version: 20.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: cryptodev
          Assignee: dev@dpdk.org
          Reporter: changchun.zhang@oracle.com
  Target Milestone: ---

This is a bug for AESNI_MB PMD in DPDK 20.11. The issue may have been resolved
in latest DPDK, but wondering if a patch can be applied for 20.11.

The AESNI_MB PMD in DPDK 20.11 does not work well in supporting multi-process.
The crash can be seen by this sequence:
1. The crypto_aesni_mb is started successfuly on primary process by
rte_vdev_init. 
2. The secondary process launches the scanning/prob procedure and the primary
process received the sync req and replied the secondary process. The
crypto_aesni_mb is also started by the probe on receiving the reply of the
vdev_scan.
3. On primary process, the packet process tries to create the crypto session
and it crashes on accessing the mb_mgr of dev->data->dev_private, in
aesni_mb_set_session_auth_parameters()

It is found in cryptodev_aesni_mb_create(), 
mb_mgr = alloc_init_mb_mgr(vector_mode);
can be triggered on both primary process and second process. Thus after the
device is started on primary, the dev->data->dev_private->mb_mgr can be updated
when second process started the device again. This is incorrect. 

The mb_mgr allocation should be limited to primary process. The same should be
applied to the qp->mb_mgr when setup the queue pair.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2022-02-07  0:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-934-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).